fix: remove unused 'default' field from feature_config_t #1231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'default' field was being serialized to fpm.toml but was never used for any logic. This caused 'fpm new' to generate manifests with an invalid 'default' key that would fail validation during build. Removes the field declaration, serialization, deserialization, and all assignments of this unused field.
Verifies that the manifest generated by 'fpm new' is valid by attempting to build the created package. This catches issues like invalid keys in the generated fpm.toml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
defaultfield fromfeature_config_tthat was causingfpm newto generate invalid manifestsnew_testthat verifies generated packages can be builtFixes #1230
Note: Default features functionality will be addressed in a separate PR.