fix: resolve MPI linker group issues and propagate library search paths#1250
Open
ijatinydv wants to merge 1 commit intofortran-lang:mainfrom
Open
fix: resolve MPI linker group issues and propagate library search paths#1250ijatinydv wants to merge 1 commit intofortran-lang:mainfrom
ijatinydv wants to merge 1 commit intofortran-lang:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the linking failures reported in #1226, specifically for projects using external C++ dependencies like libtorch.
Key Fixes:
-Wl,--end-groupinsrc/metapackage/fpm_meta_mpi.f90. Previously, the unclosed group caused the linker to incorrectly wrap subsequent libraries into the circular dependency search, leading to resolution errors.src/fpm_targets.f90to extract-Lsearch paths fromc-flagsandcxx-flags. This ensures these paths are actually passed to the Fortran linker during the executable link step, which was previously missing.Testing:
extract_library_pathswith various inputs (single/multiple paths, no paths, and trailing flags).fpm testand verified standard builds to ensure no regressions in core dependency handling.Closes #1226