-
Notifications
You must be signed in to change notification settings - Fork 100
[PATCH] Release and Chrome webstore workflow changes. #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Vedansh Saini <[email protected]>
Reviewer's GuideAutomates draft release creation and CHANGELOG generation in the release-drafter workflow, commits and tags releases, and enhances the Chrome Web Store publish workflow to use release tags, validate zip contents (including manifest.json), and automatically upload and publish extensions. Sequence diagram for automated release and Chrome Web Store publish processsequenceDiagram
participant Dev as Developer
participant GH as GitHub
participant RD as Release Drafter Workflow
participant PT as Publish to Chrome Workflow
participant CWS as "Chrome Web Store"
Dev->>GH: Merge PR to master
GH->>RD: Trigger release-drafter workflow
RD->>GH: Create draft release
RD->>GH: Generate/Prepend CHANGELOG
RD->>GH: Commit CHANGELOG & create tag
RD->>GH: Push tag to origin
GH->>PT: Trigger publish-to-chrome workflow (on release tag)
PT->>GH: Checkout code at release tag
PT->>GH: Create ZIP (validate manifest.json)
PT->>CWS: Upload & publish extension
Flow diagram for enhanced Chrome Web Store publish workflowflowchart TD
A["Release Tag Created"] --> B["Checkout Code at Tag"]
B --> C["Create ZIP from src/"]
C --> D["Validate manifest.json at ZIP root"]
D --> E["Upload & Publish to Chrome Web Store"]
E --> F["Extension Available on Chrome Web Store"]
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `.github/workflows/publish-to-chrome.yml:27` </location>
<code_context>
+ zip -r ../scrum-helper.zip . >/dev/null
+ echo "Created zip:"
+ unzip -l ../scrum-helper.zip
+ if unzip -l ../scrum-helper.zip | awk '{print $4}' | grep -q '^manifest.json$'; then
+ echo "mannifest.json is at zip root"
+ else
+ echo "ERROR: manifest.json NOT at zip root; zip will fail on Chrome Web Store"
</code_context>
<issue_to_address>
Typo in echo statement: 'mannifest.json' should be 'manifest.json'.
Please update the echo statement to use the correct spelling: 'manifest.json'.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
echo "mannifest.json is at zip root"
=======
echo "manifest.json is at zip root"
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Signed-off-by: Vedansh Saini <[email protected]>
Summary Of Changes
The changes in this PR intends to create a draft whenever a new PR is merged into master and draft a release based on that, which can be published manually. Along with the publish of release it would be automatically zipped and pushed to the Chrome web store.