feat:update filter caption and tool description#622
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates English-only filter labels and tooltips in the popup to reflect the actual filter behavior (no longer claiming exclusivity with "only"), and aligns the inline popup.html text with the i18n messages for issues and PR-related filters. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
data-i18nattributes still point to the same keys while the inline English strings have changed; consider updating the correspondingmessages.jsonentries or removing the inline text to avoid inconsistent translations depending on how i18n is applied. - The
onlyRevPRstooltip still uses theonlyPRsTooltipi18n key, which looks like a copy-paste oversight; consider adding and referencing a dedicated key (e.g.,onlyRevPRsTooltip) to keep messages semantically aligned with the filter.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `data-i18n` attributes still point to the same keys while the inline English strings have changed; consider updating the corresponding `messages.json` entries or removing the inline text to avoid inconsistent translations depending on how i18n is applied.
- The `onlyRevPRs` tooltip still uses the `onlyPRsTooltip` i18n key, which looks like a copy-paste oversight; consider adding and referencing a dedicated key (e.g., `onlyRevPRsTooltip`) to keep messages semantically aligned with the filter.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
This PR updates the English UI copy for the “Advanced Filters” checkboxes in the popup to better reflect intended behavior, adjusting both the inline fallback text in popup.html and the English locale strings in messages.json.
Changes:
- Updated English captions/tooltips for “Only Issues”, “Only PRs”, “Only Reviewed PRs”, and “Only Merged PRs”.
- Updated the corresponding English i18n strings in
src/_locales/en/messages.json. - Updated inline fallback text in
src/popup.htmlfor the same controls.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/popup.html | Updates inline (fallback) labels/tooltips for the filter checkboxes; includes a tooltip i18n key mismatch for Reviewed PRs. |
| src/_locales/en/messages.json | Updates English i18n strings for the filter labels/tooltips; some wording now conflicts with actual exclusive-filter behavior and has stale description metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@kaungmyatshwe1397 please link this PR to an issue |
PhilixTheExplorer
left a comment
There was a problem hiding this comment.
@kaungmyatshwe1397 Thanks for cleaning up the filter wording, the new labels are clearer. One small existing-looking issue: in src/popup.html around line 267, the reviewed PR tooltip still uses data-i18n="onlyPRsTooltip" while the fallback text refers to reviewed PRs. Since this PR is touching that text, could we update it to onlyRevPRsTooltip as well so the localized tooltip matches?
|
@PhilixTheExplorer |
📌 Fixes
#578
📝 Summary of Changes
📸 Screenshots / Demo (if UI-related)
✅ Checklist
👀 Reviewer Notes
Captions and tool-tip description of filters are only updated in English language and will update for other remaining languages by separate PRs if this is accepted. Also update inline description from popup.html even though message is coming form data-i18n.
Summary by Sourcery
Update filter labels and tooltips to reflect that filters include additional items instead of restricting results to only those items.
Bug Fixes:
Enhancements: