Skip to content

feat:update filter caption and tool description#622

Closed
kaungmyatshwe1397 wants to merge 7 commits into
fossasia:mainfrom
kaungmyatshwe1397:updateFilterDescription
Closed

feat:update filter caption and tool description#622
kaungmyatshwe1397 wants to merge 7 commits into
fossasia:mainfrom
kaungmyatshwe1397:updateFilterDescription

Conversation

@kaungmyatshwe1397
Copy link
Copy Markdown
Contributor

@kaungmyatshwe1397 kaungmyatshwe1397 commented May 7, 2026

📌 Fixes

#578


📝 Summary of Changes

  • Updating Filter and its tool tip description in English to match actual behavior
  • This is new PRs opened to fix the related issue in alternative way

📸 Screenshots / Demo (if UI-related)

Screenshot 2026-05-07 151531

✅ Checklist

  • I’ve tested my changes locally
  • I’ve added tests (if applicable)
  • I’ve updated documentation (if applicable)
  • My code follows the project’s code style guidelines

👀 Reviewer Notes

Captions and tool-tip description of filters are only updated in English language and will update for other remaining languages by separate PRs if this is accepted. Also update inline description from popup.html even though message is coming form data-i18n.

Summary by Sourcery

Update filter labels and tooltips to reflect that filters include additional items instead of restricting results to only those items.

Bug Fixes:

  • Correct filter captions and tooltips so their descriptions align with the actual report behavior for issues and PR-related filters.

Enhancements:

  • Clarify English UI copy for issue, PR, reviewed PR, and merged PR filters in the popup to better match their functionality.

Copilot AI review requested due to automatic review settings May 7, 2026 08:23
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented May 7, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates English-only filter labels and tooltips in the popup to reflect the actual filter behavior (no longer claiming exclusivity with "only"), and aligns the inline popup.html text with the i18n messages for issues and PR-related filters.

File-Level Changes

Change Details Files
Relaxed "only" wording in filter labels and tooltips to match actual non-exclusive filter behavior for issues and PRs.
  • Updated issue filter label text to drop "only" while keeping existing i18n key wiring.
  • Updated issue filter tooltip text to clarify that issues created or assigned to the user are included, not exclusively.
  • Updated PR filter label and tooltip text to drop "only" and describe included PRs created by the user.
  • Updated reviewed PR filter label and tooltip text to drop "only" and describe included PRs reviewed by the user.
  • Updated merged PR filter label and tooltip text to drop "only" and describe that merged PRs are included, still requiring a GitHub token.
src/popup.html
src/_locales/en/messages.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The data-i18n attributes still point to the same keys while the inline English strings have changed; consider updating the corresponding messages.json entries or removing the inline text to avoid inconsistent translations depending on how i18n is applied.
  • The onlyRevPRs tooltip still uses the onlyPRsTooltip i18n key, which looks like a copy-paste oversight; consider adding and referencing a dedicated key (e.g., onlyRevPRsTooltip) to keep messages semantically aligned with the filter.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The `data-i18n` attributes still point to the same keys while the inline English strings have changed; consider updating the corresponding `messages.json` entries or removing the inline text to avoid inconsistent translations depending on how i18n is applied.
- The `onlyRevPRs` tooltip still uses the `onlyPRsTooltip` i18n key, which looks like a copy-paste oversight; consider adding and referencing a dedicated key (e.g., `onlyRevPRsTooltip`) to keep messages semantically aligned with the filter.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the English UI copy for the “Advanced Filters” checkboxes in the popup to better reflect intended behavior, adjusting both the inline fallback text in popup.html and the English locale strings in messages.json.

Changes:

  • Updated English captions/tooltips for “Only Issues”, “Only PRs”, “Only Reviewed PRs”, and “Only Merged PRs”.
  • Updated the corresponding English i18n strings in src/_locales/en/messages.json.
  • Updated inline fallback text in src/popup.html for the same controls.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
src/popup.html Updates inline (fallback) labels/tooltips for the filter checkboxes; includes a tooltip i18n key mismatch for Reviewed PRs.
src/_locales/en/messages.json Updates English i18n strings for the filter labels/tooltips; some wording now conflicts with actual exclusive-filter behavior and has stale description metadata.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/popup.html
Comment thread src/_locales/en/messages.json
Comment thread src/_locales/en/messages.json
Comment thread src/_locales/en/messages.json
Comment thread src/_locales/en/messages.json
@hpdang
Copy link
Copy Markdown
Member

hpdang commented May 8, 2026

@kaungmyatshwe1397 please link this PR to an issue

@kaungmyatshwe1397
Copy link
Copy Markdown
Contributor Author

@hpdang
PR is linked to related issue now .
#578 is the old closed PR of this updated PR to that issue.
Thanks.

Copy link
Copy Markdown
Contributor

@PhilixTheExplorer PhilixTheExplorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaungmyatshwe1397 Thanks for cleaning up the filter wording, the new labels are clearer. One small existing-looking issue: in src/popup.html around line 267, the reviewed PR tooltip still uses data-i18n="onlyPRsTooltip" while the fallback text refers to reviewed PRs. Since this PR is touching that text, could we update it to onlyRevPRsTooltip as well so the localized tooltip matches?

@kaungmyatshwe1397
Copy link
Copy Markdown
Contributor Author

@PhilixTheExplorer
Thanks for mention this.
Since it will need multiple simple changes for every message json file.
So , i will open this as a separate PRs with good first issue label for other contributors.

Copy link
Copy Markdown
Contributor

@PhilixTheExplorer PhilixTheExplorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copilot AI review requested due to automatic review settings May 15, 2026 08:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

Comment thread src/popup.html
Comment thread src/_locales/en/messages.json
Comment thread src/_locales/en/messages.json
Comment thread src/scripts/main.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants