Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed UI Issue with Checkbox Selection/Deselection Feedback #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yaxit24
Copy link

@yaxit24 yaxit24 commented Apr 1, 2025

Changes made:
Implemented color transitions from gray to blue when checkboxes are checked/unchecked to provide clear visual feedback
For the checkbox color transitions from gray to blue, I aimed to give a subtle yet clear visual. The label text starts as Grey then transitions smoothly to Blue, and have also increased the font size to 500.

Screenshots for the change:

Screenshot 2025-04-01 at 11 39 37 PM

Summary by Sourcery

Enhance user interface by adding visual feedback for checkbox interactions through color and styling transitions

New Features:

  • Add visual state changes for checkboxes, including color transition from gray to blue and font weight adjustment

Enhancements:

  • Implement smooth color and styling transitions for checkboxes to improve user interaction feedback

Copy link

sourcery-ai bot commented Apr 1, 2025

Reviewer's Guide by Sourcery

This pull request enhances the user experience by providing visual feedback when checkboxes and switches are interacted with. It introduces color transitions and font-weight changes to indicate the checked/unchecked state, improving clarity for the user.

Class diagram for Checkbox Styling

classDiagram
  class Checkbox {
    +color: #757575
    +transition: color 0.3s ease, font-weight 0.3s ease, background-color 0.3s ease
    +padding-left: 35px
  }
  class CheckboxChecked {
    +color: #3f51b5
    +font-weight: 500
    +background-color: rgba(63, 81, 181, 0.03)
  }
  Checkbox --|> CheckboxChecked : when checked
  note for Checkbox "Initial state of the checkbox"
  note for CheckboxChecked "State of the checkbox when checked"
Loading

File-Level Changes

Change Details Files
Implemented visual feedback for checkbox and switch elements to improve user interaction.
  • Added a color transition from gray to blue when checkboxes are checked, and back when unchecked.
  • Increased the font weight of the label text when the checkbox is checked.
  • Added a subtle background color highlight to the label when the checkbox is checked.
  • Ensured proper spacing between the checkbox and label text.
  • Applied similar styling to switch labels for consistency.
src/index.css

Possibly linked issues

  • #123: The PR fixes the UI issue by implementing color transitions from gray to blue when checkboxes are checked/unchecked.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yaxit24 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider defining the color and font weight variables to ensure consistency and easier modification in the future.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@yaxit24
Copy link
Author

yaxit24 commented Apr 1, 2025

@hongquan @mariobehling, please review my PR. Please guide me on any further changes.

@yaxit24
Copy link
Author

yaxit24 commented Apr 2, 2025

Screenshot 2025-04-01 at 11 56 50 PM sorry this is the correct screenshot.

@Preeti9764
Copy link

@yaxit24 Hey just a suggestion I don't think the bright color and font weight changes you made go well
with the overall UI theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants