-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed UI Issue with Checkbox Selection/Deselection Feedback #70
base: master
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request enhances the user experience by providing visual feedback when checkboxes and switches are interacted with. It introduces color transitions and font-weight changes to indicate the checked/unchecked state, improving clarity for the user. Class diagram for Checkbox StylingclassDiagram
class Checkbox {
+color: #757575
+transition: color 0.3s ease, font-weight 0.3s ease, background-color 0.3s ease
+padding-left: 35px
}
class CheckboxChecked {
+color: #3f51b5
+font-weight: 500
+background-color: rgba(63, 81, 181, 0.03)
}
Checkbox --|> CheckboxChecked : when checked
note for Checkbox "Initial state of the checkbox"
note for CheckboxChecked "State of the checkbox when checked"
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @yaxit24 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider defining the color and font weight variables to ensure consistency and easier modification in the future.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@hongquan @mariobehling, please review my PR. Please guide me on any further changes. |
@yaxit24 Hey just a suggestion I don't think the bright color and font weight changes you made go well |
Changes made:
Implemented color transitions from gray to blue when checkboxes are checked/unchecked to provide clear visual feedback
For the checkbox color transitions from gray to blue, I aimed to give a subtle yet clear visual. The label text starts as Grey then transitions smoothly to Blue, and have also increased the font size to 500.
Screenshots for the change:
Summary by Sourcery
Enhance user interface by adding visual feedback for checkbox interactions through color and styling transitions
New Features:
Enhancements: