Skip to content

Fixes issue #69 : Enhanced feedback to Selection/Deselection of CheckBox #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes issue #69 : Enhanced feedback to Selection/Deselection of CheckBox #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,17 @@ li {
list-style-type: disc !important;
margin-left: 1rem;
}
.selectedLabel {
font-weight: 400;
color: #333333;
}

.unselectedLabel {
font-weight: 300;
color: #666666;
}

.selectedLabel, .unselectedLabel {
transition: color 0.3s ease-in-out, font-weight 0.3s ease-in-out;
}

34 changes: 25 additions & 9 deletions src/scripts/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,19 +82,25 @@ function handleEndingDateChange() {
}
function handleLastWeekContributionChange() {
var value = lastWeekContributionElement.checked;
var labelElement = document.querySelector("label[for='lastWeekContribution']");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (complexity): Consider creating a helper function to toggle the label classes to reduce code duplication in the handleLastWeekContributionChange and handleOpenLabelChange functions

You can reduce duplication by extracting the label toggling logic into a helper function. For example:

function updateLabelClass(labelElement, isSelected) {
  labelElement.classList.toggle("selectedLabel", isSelected);
  labelElement.classList.toggle("unselectedLabel", !isSelected);
}

Then update your handlers to use the helper:

function handleLastWeekContributionChange() {
  var value = lastWeekContributionElement.checked;
  var labelElement = document.querySelector("label[for='lastWeekContribution']");
  if (value) {
    startingDateElement.disabled = true;
    endingDateElement.disabled = true;
    endingDateElement.value = getToday();
    startingDateElement.value = getLastWeek();
    updateLabelClass(labelElement, true);
    handleEndingDateChange();
    handleStartingDateChange();
  } else {
    startingDateElement.disabled = false;
    endingDateElement.disabled = false;
    updateLabelClass(labelElement, false);
  }
  chrome.storage.local.set({ lastWeekContribution: value });
}

function handleOpenLabelChange() {
  var value = showOpenLabelElement.checked;
  var labelElement = document.querySelector("label[for='showOpenLabel']");
  updateLabelClass(labelElement, value);
  chrome.storage.local.set({ showOpenLabel: value });
}

This removes duplicated code while keeping functionality intact.


if (value) {
startingDateElement.disabled = true;
endingDateElement.disabled = true;
endingDateElement.value = getToday();
startingDateElement.value = getLastWeek();
handleEndingDateChange();
handleStartingDateChange();
startingDateElement.disabled = true;
endingDateElement.disabled = true;
endingDateElement.value = getToday();
startingDateElement.value = getLastWeek();
labelElement.classList.add("selectedLabel");
labelElement.classList.remove("unselectedLabel");
} else {
startingDateElement.disabled = false;
endingDateElement.disabled = false;
startingDateElement.disabled = false;
endingDateElement.disabled = false;
labelElement.classList.add("unselectedLabel");
labelElement.classList.remove("selectedLabel");
}

chrome.storage.local.set({ lastWeekContribution: value });
}

function getLastWeek() {
var today = new Date();
var noDays_to_goback = gsoc == 0 ? 7 : 1;
Expand Down Expand Up @@ -135,9 +141,19 @@ function handleProjectNameChange() {
}
function handleOpenLabelChange() {
var value = showOpenLabelElement.checked;
var labelElement = document.querySelector("label[for='showOpenLabel']");

if (value) {
labelElement.classList.add("selectedLabel");
labelElement.classList.remove("unselectedLabel");
} else {
labelElement.classList.add("unselectedLabel");
labelElement.classList.remove("selectedLabel");
}

chrome.storage.local.set({ showOpenLabel: value });
chrome.storage.local.set({ showClosedLabel: value });
}

function handleUserReasonChange() {
var value = userReasonElement.value;
chrome.storage.local.set({ userReason: value });
Expand Down