-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
outlook bug #81
base: master
Are you sure you want to change the base?
outlook bug #81
Conversation
Signed-off-by: Vedansh Saini <[email protected]>
Reviewer's Guide by SourceryThis pull request updates the selectors for Outlook to ensure the proper injection of scrum data into the body and subject fields. The selectors for the body and subject input fields have been updated to reflect the latest changes in Outlook's UI. Updated class diagram for EmailClientAdapterclassDiagram
class EmailClientAdapter {
-emailClient
+constructor(emailClient: string)
+getSelectors(): object
+getEventTypes(): object
+inject(body: string, subject: string): void
}
EmailClientAdapter -- OutlookSelectors : has a
class OutlookSelectors{
-body: string
-subject: string
}
note for OutlookSelectors "Selectors for Outlook were updated"
OutlookSelectors -- string : body
OutlookSelectors -- string : subject
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vedansh-5 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment explaining why the selectors changed, possibly referencing the Outlook update.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Closes #80
Changes: The selectors of outlook are updated in the latest changes and now works properly by injecting the scrum
body
in the body area andsubject
in the subject area.Screenshots for the change:

Summary by Sourcery
Bug Fixes: