chore(compilers): remove Solc AST-based Flattener - #107
Open
jose-compu wants to merge 1 commit into
Open
Conversation
Drop the legacy Flattener that compiled via Solc solely to obtain ASTs. Flattening now relies exclusively on the Solar-based ProjectPathsConfig::flatten path. Closes foundry-rs/foundry#10965
jose-compu
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse,
onbjerg and
stevencartavia
as code owners
July 2, 2026 17:30
mablr
reviewed
Jul 2, 2026
mablr
left a comment
mablr
left a comment
Member
There was a problem hiding this comment.
Makes sense, thank you! Please fix CI.
DaniPopes
reviewed
Jul 2, 2026
| } | ||
|
|
||
| #[test] | ||
| fn can_flatten_with_duplicates() { |
Member
There was a problem hiding this comment.
we should keep all the tests and convert them if necessary.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the legacy Flattener that compiled via Solc solely to obtain ASTs. Flattening now relies exclusively on the Solar-based ProjectPathsConfig::flatten path.
Closes foundry-rs/foundry#10965
Details
Flattenerfromfoundry-compilersProjectPathsConfig::flattenas the sole flatten implementationCloses foundry-rs/foundry#10965
Test plan
cargo test -p foundry-compilers --features="full project-util test-utils" --test project -- can_flattencargo test -p foundry-compilers --features="full project-util test-utils" --test project -- cannot_flatten