Skip to content

feat(forge): truncate large data in execution traces #10305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tracked by #10183
grandizzy opened this issue Apr 15, 2025 · 4 comments
Open
Tracked by #10183

feat(forge): truncate large data in execution traces #10305

grandizzy opened this issue Apr 15, 2025 · 4 comments
Assignees
Labels
A-tracing Area: tracing C-forge Command: forge T-feature Type: feature

Comments

@grandizzy
Copy link
Collaborator

grandizzy commented Apr 15, 2025

Component

Forge

Describe the feature you would like

from @hexonaut - add an arg to truncate function call input/output in the execution trace - we have some functions that pass large byte arrays and it makes the execution trace pretty useless.

Additional context

Edit: Started on revm-inspectors side paradigmxyz/revm-inspectors#283

@grandizzy grandizzy added T-feature Type: feature T-needs-triage Type: this issue needs to be labelled labels Apr 15, 2025
@github-project-automation github-project-automation bot moved this to Todo in Foundry Apr 15, 2025
@zerosnacks zerosnacks added C-forge Command: forge A-tracing Area: tracing and removed T-needs-triage Type: this issue needs to be labelled labels Apr 15, 2025
@grandizzy grandizzy assigned yash-atreya and unassigned grandizzy Apr 15, 2025
@yash-atreya
Copy link
Member

We're blocked by the revm migration here #10183 if we want to include this config as part of revm-inspectors since inspectors have already been bumped to new revm

cc @grandizzy @zerosnacks

@drortirosh
Copy link

Suggestion: instead of just truncation, maybe reduce repeated dumps:
That is, the parser "remembers" structs, and if a struct is dumped again , either as part of input or output, just "name" it instead of full dump.

This would also help dumps of erc4337, where a "UserOperation" struct is passed several times, and at times it can be few Ks.

@hexonaut
Copy link
Contributor

Suggestion: instead of just truncation, maybe reduce repeated dumps: That is, the parser "remembers" structs, and if a struct is dumped again , either as part of input or output, just "name" it instead of full dump.

This would also help dumps of erc4337, where a "UserOperation" struct is passed several times, and at times it can be few Ks.

In the case I mentioned the byte array changes every time, so not sure if this will help.

@jenpaff
Copy link
Collaborator

jenpaff commented Apr 23, 2025

blocked by revm bump

@jenpaff jenpaff moved this from In Progress to Blocked in Foundry Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tracing Area: tracing C-forge Command: forge T-feature Type: feature
Projects
Status: Blocked
Development

No branches or pull requests

6 participants