chore: bump revm to 21.0.0 release
#10183
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r performance impact or whether it will work with cheatcode macros
zerosnacks
commented
Apr 2, 2025
zerosnacks
commented
Apr 2, 2025
Comment on lines
55
to
+60
| if let Some(l1_block_number) = block | ||
| .other_fields() | ||
| .and_then(|other| other.get("l1BlockNumber").cloned()) | ||
| .and_then(|l1_block_number| { | ||
| serde_json::from_value::<U256>(l1_block_number).ok() | ||
| }) | ||
| .and_then(|v| v.as_u64()) | ||
| { | ||
| env.block.number = l1_block_number; | ||
| env.evm_env.block_env.number = l1_block_number; |
There was a problem hiding this comment.
l1_block_number no longer exists, only in op-revm. We may need to always use op-revm considering we also need it for Anvil
There was a problem hiding this comment.
After looking into this I think we can integrate it inside of Foundry EVM, I'm wondering what length we should go to for OP compatibility.
zerosnacks
changed the title
revm to 20.0.0 releaserevm to 21.0.0 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Opening for visibility / easier collaboration
Restructured commit history so it is easier to revert to known good changes whilst iteratively implementing the complex changes (handler, journal)
Uses #10051 as reference
CI is expected to be failing for quite some time
Solution
Depends on:
Next steps:
foundry-evm-corecrate, preferring internal mapping types rather than direct replacement - similar to Ethers > Alloy migration processEvmContext/InnerEvmContextsuccessorinterpreter.shared_memorysuccessorIssues:
with_evmcopiesl1_block_info, this field no longer exists yielding the question whether Cheatcodes, like Anvil, expectsOpEvmget_prankcheatcode expectsdepthto be au64, not ausize-try_into?worksPatternccx.ecx.journaled_state.load_account(&mut ccx.ecx.db(), *from)causescannot borrowccx.ecxas mutable more than once at a time second mutable borrow occurs herePR Checklist