New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(abi): Implement UIfmt for DSTest console logs #10185

Open

VolodymyrBg wants to merge 1 commit into foundry-rs:master from VolodymyrBg:bg

VolodymyrBg commented Mar 26, 2025

Motivation

TODO in the file.
Implemented the TODO to use UIfmt for DSTest console logs in the ds.rs file.

Solution

Added import for UIfmt from foundry_common_fmt
Updated display attributes to use UIfmt::pretty() for values formatting
Applied UIfmt to both regular values and array elements
Improved formatting consistency across all console log events

PR Checklist

Added Tests
Added Documentation
Breaking changes


          feat(abi): Implement UIfmt for DSTest console logs

4ff44fe

VolodymyrBg requested review from DaniPopes, klkvr, mattsse, grandizzy, yash-atreya and zerosnacks as code owners

March 26, 2025 19:04

Author

VolodymyrBg commented Mar 28, 2025

@mattsse Could you check it please when you have a free moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

klkvr Awaiting requested review from klkvr klkvr is a code owner

mattsse Awaiting requested review from mattsse mattsse is a code owner

grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet