Skip to content

feat(cast): getTransactionBySenderAndNonce #10323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2025
Merged

feat(cast): getTransactionBySenderAndNonce #10323

merged 2 commits into from
Apr 17, 2025

Conversation

yash-atreya
Copy link
Member

Motivation

Currently, cast tx only works by passing the tx_hash. We can leverage the eth_getTransactionBySenderAndNonce RPC endpoint by adding --from and --nonce optional flags.

Solution

  • Make tx_hash optional
  • Add from and nonce args to the subcommand (also optional)
  • Make raw_request to eth_getTransactionBySenderAndNonce

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@yash-atreya yash-atreya enabled auto-merge (squash) April 17, 2025 07:12
zerosnacks
zerosnacks previously approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@yash-atreya yash-atreya disabled auto-merge April 17, 2025 07:17
@yash-atreya yash-atreya enabled auto-merge (squash) April 17, 2025 07:18
grandizzy
grandizzy approved these changes Apr 17, 2025
View reviewed changes
Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@yash-atreya yash-atreya merged commit 23b1cbd into master Apr 17, 2025
22 checks passed
@yash-atreya yash-atreya deleted the yash/tx-sender-nonce branch April 17, 2025 07:36
@grandizzy grandizzy added T-feature Type: feature C-cast Command: cast labels Apr 17, 2025
@yash-atreya yash-atreya self-assigned this Apr 22, 2025
@yash-atreya yash-atreya moved this to Done in Foundry Apr 22, 2025
@grandizzy grandizzy moved this from Done to Completed in Foundry Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grandizzy grandizzy grandizzy approved these changes

@zerosnacks zerosnacks zerosnacks left review comments

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees

@yash-atreya yash-atreya

Labels
C-cast Command: cast T-feature Type: feature
Projects
Foundry
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yash-atreya @grandizzy @zerosnacks