fix: improve accuracy of vanity wallet function comments #11145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Galoretka
requested review from
DaniPopes,
klkvr,
mattsse and
grandizzy
as code owners
Rahul-cyber26
approved these changes
Jul 29, 2025
Rahul-cyber26
suggested changes
Jul 29, 2025
Merged
pull bot
pushed a commit
to DIGIIX-Ltd/foundry
that referenced
this pull request
Aug 21, 2025
* chore: aggregate PRs This PR aggregates changes from the following PRs: - Closes foundry-rs#11145 by @\Galoretka - Closes foundry-rs#11320 by @\ANtutov - Closes foundry-rs#11379 by @\bethoffman * pr 11294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix misleading comments in vanity wallet functions:
The create_matcher function does not use nonce and checks wallet addresses directly,
while create_nonce_matcher uses nonce to check contract addresses created with
the specified nonce.