feat: add nushell completions #11311
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `clap_complete` doesn't come with nushell completions built-in but they have another crate `clap_complete_nushell` that does. Sucks it isn't supported by default, see clap-rs/clap#5880. This PR implements a wrapper around the enum with nushell included to support nushell completions too. - moved `clap_complete` to workspace dependency to prevent conflicting versions between foundry-common and cast/anvil/forge.
0xferrous
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
|
Implementation makes sense though I'm a bit concerned about leaking these internals into Foundry |
|
What is the concern? I guess I can publish a mini crate that wraps this and exposes this functionality so the code stays the same as before? But I think security wise this is probably better to have the code in foundry and trust only the official clap crates. |
|
That as you stated this logic is a concern of the library and not the implementation. That said, I am OK with merging this considering this is a small ask and the discussion upstream looks stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Getting command completions in nushell.
Solution
clap_completedoesn't come with nushell completions built-in but they have another crateclap_complete_nushellthat does. Sucks it isn't supported by default, see Why are the nushell completions not part of the completions crate? clap-rs/clap#5880. This PR implements a wrapper around the enum with nushell included to support nushell completions too.clap_completeto workspace dependency to prevent conflicting versions between foundry-common and cast/anvil/forge.PR Checklist