fix(common): preserve contract type in try new by wrapping deployCode #11984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng vm.deployCode with {Name}(payable(...))
phrwlk
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg,
yash-atreya and
zerosnacks
as code owners
3 tasks
|
thank you! that's a valid bug but needs a little bit more complex fix, will include in #12050 with the test you added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dynamic test linking preprocessor failed to preserve the contract type for try-constructor statements. For code like try new C(...) returns (C c) { ... }, the transformation produced vm.deployCode(...) without wrapping, leaving the expression typed as address. This mismatched the expected type C and could fail compilation when a returns (C) clause was present.
This change unifies handling for both try and non-try constructor creations by always wrapping the transformed expression as C(payable(vm.deployCode({...}))), ensuring the resulting type remains the contract type. Added a CLI test that asserts try new C(...) returns (C c) compiles after preprocessing.