Skip to content

Conversation

CreeptoGengar
Copy link
Contributor

Improve error handling in WalletSigner::available_senders method

This commit addresses the issue where errors when retrieving addresses from hardware wallets (Ledger/Trezor) were silently ignored, making it difficult for users to understand why some addresses might be unavailable.

Why these changes are necessary:

  1. Silent error ignoring made debugging hardware wallet issues nearly impossible
  2. Users had no visibility into why certain addresses were missing from results
  3. Potential duplicate addresses could confuse users when both LedgerLive and
    Legacy derivation paths returned the same address
  4. The graceful degradation pattern is preserved while adding observability

Copy link
Contributor

@0xrusowsky 0xrusowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address the feedback and ensure the CI is green by running rustfmt

@CreeptoGengar
Copy link
Contributor Author

CreeptoGengar commented Oct 8, 2025

@0xrusowsky thanks for the feedback, I fixed it and also fixed rustfmt,

but there're other CI's failing, do they related to mine PR? for me it seems they aren't

@grandizzy
Copy link
Collaborator

@0xrusowsky thanks for the feedback, I fixed it and also fixed rustfmt,

but there're other CI's failing, do they related to mine PR? for me it seems they aren't

Please merge in master to fix those

@0xrusowsky 0xrusowsky enabled auto-merge (squash) October 8, 2025 14:16
@0xrusowsky 0xrusowsky merged commit e2f27e3 into foundry-rs:master Oct 8, 2025
16 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants