feat: add support for basic vyper project using forge init --vyper #9930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
startup-dreamer
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
zerosnacks
reviewed
Feb 21, 2025
There was a problem hiding this comment.
Hi @startup-dreamer, thanks for your PR
I would prefer if the Vyper template used local files, see: https://github.com/foundry-rs/foundry/tree/master/crates/forge/assets
We will have to move the Solidity ones in their respective subfolder in the assets directory and create a Vyper equivalent
Thanks!
|
Makes sense, I'll do the changes. |
|
Hey @startup-dreamer, if time permits - would be great to get this in! Thanks |
I will try to ship this by the end of weekend. |
startup-dreamer
force-pushed
the
feat/add_forge_vyper_init_flag
branch
from
5528dc5 to
985132e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
startup-dreamer
force-pushed
the
feat/add_forge_vyper_init_flag
branch
from
985132e to
ec2d2f1
Compare
startup-dreamer
force-pushed
the
feat/add_forge_vyper_init_flag
branch
from
ec2d2f1 to
5b06b8e
Compare
|
Thanks! This is looking great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8340
This PR aims to add
forge init --vypercommand which instantiate a basic vyper project like this project as suggested here #8340 (comment).This command mimicsforge init --template https://github.com/Patronum-Labs/foundry-vypercurrently the standard way of initializing a vyper project.PR Checklist