Update sncast scripts #3076
Merged
Update sncast scripts #3076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
franciszekjob
changed the title
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
franciszekjob
requested review from
ddoktorski and
kkawula
and removed request for
a team
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
ddoktorski
reviewed
Mar 24, 2025
franciszekjob
requested review from
ddoktorski
and removed request for
ddoktorski
ddoktorski
reviewed
Mar 24, 2025
crates/sncast/tests/data/scripts/map_script/scripts/src/map_script.cairo
Outdated
Show resolved
Hide resolved
sncast_std/src/lib.cairo
Outdated
Comment on lines
230
to
238
| pub struct FeeSettings { | ||
| pub max_fee: Option<felt252>, | ||
| pub max_gas: Option<u64>, | ||
| pub max_gas_unit_price: Option<u128>, | ||
| pub l1_gas: Option<u64>, | ||
| pub l1_gas_price: Option<u128>, | ||
| pub l2_gas: Option<u64>, | ||
| pub l2_gas_price: Option<u128>, | ||
| pub l1_data_gas: Option<u64>, | ||
| pub l2_data_gas_price: Option<u128>, | ||
| } |
There was a problem hiding this comment.
Is it exactly the same logic as with the flags?
cptartur
reviewed
Mar 24, 2025
ddoktorski
approved these changes
Mar 25, 2025
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
cptartur
approved these changes
Mar 25, 2025
franciszekjob
merged commit d6196d9
into
franciszekjob/2490-rpc-0.8.0
20 of 21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3102
Towards #2490
Introduced changes
FeeSettingsstructChecklist
CHANGELOG.md