Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add erc20-contract template #3110

Merged
merged 14 commits into from
Mar 28, 2025
Merged

Add erc20-contract template #3110

merged 14 commits into from
Mar 28, 2025

Conversation

ddoktorski
Copy link
Contributor

Closes #2850

Introduced changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@ddoktorski ddoktorski requested a review from a team as a code owner March 17, 2025 17:52
@ddoktorski ddoktorski requested review from franciszekjob, kkawula and cptartur and removed request for a team March 17, 2025 17:52
@ddoktorski ddoktorski force-pushed the 2850-erc-20-template branch from f44666b to e0ef160 Compare March 17, 2025 17:55
cptartur
cptartur reviewed Mar 21, 2025
View reviewed changes
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't review the contract code. I'm assuming it was taken from somewhere that makes sense.

@ddoktorski ddoktorski requested a review from cptartur March 21, 2025 11:50
franciszekjob
franciszekjob reviewed Mar 23, 2025
View reviewed changes
Copy link
Contributor

@franciszekjob franciszekjob left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also mention somewhere in the forge guide that it's possible to use this template.

cptartur
cptartur approved these changes Mar 25, 2025
View reviewed changes
Base automatically changed from 2850-cairo-program-template to master March 28, 2025 12:41
@ddoktorski ddoktorski added this pull request to the merge queue Mar 28, 2025
Merged via the queue into master with commit 257e322 Mar 28, 2025
37 checks passed
@ddoktorski ddoktorski deleted the 2850-erc-20-template branch March 28, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cptartur cptartur cptartur approved these changes

@franciszekjob franciszekjob franciszekjob approved these changes

@kkawula kkawula Awaiting requested review from kkawula

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ddoktorski @cptartur @franciszekjob @kkawula