Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable braavos integration #3122

Merged
merged 64 commits into from
Mar 25, 2025
Merged

Disable braavos integration #3122

merged 64 commits into from
Mar 25, 2025

Conversation

franciszekjob
Copy link
Contributor

@franciszekjob franciszekjob commented Mar 19, 2025 •
edited
Loading

Closes #

Introduced changes

Temporarily disable integration with braavos accounts. Reason for that described in #3118

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

franciszekjob and others added 30 commits March 11, 2025 16:05
@franciszekjob
Refactor FeeSettings in sncast_std
2d56362
@franciszekjob
Merge branch 'franciszekjob/2490-rpc-0.8.0' of https://github.com/fou…
c837366 
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
@franciszekjob
Add rpc changes to sncast_std
a8d115e
@franciszekjob
Update script tests
cce8b24
@franciszekjob
Merge branch 'franciszekjob/2490-rpc-0.8.0' of https://github.com/fou…
4f9ee06 
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
@franciszekjob
Fix some script tests
35ee0b0
@franciszekjob
Merge branch 'franciszekjob/2490-rpc-0.8.0' of https://github.com/fou…
755b27c 
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
@franciszekjob
Fix linting
c4daa26
@franciszekjob
Add todos and fix tests
8321f05
@franciszekjob
Merge branch 'franciszekjob/2490-rpc-0.8.0' of https://github.com/fou…
8a69532 
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
@franciszekjob
Merge branch 'franciszekjob/2490-rpc-0.8.0' of https://github.com/fou…
caadc34 
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
@franciszekjob
Merge branch 'franciszekjob/2490-rpc-0.8.0' of https://github.com/fou…
3b3c2a9 
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
@franciszekjob
Merge branch 'franciszekjob/2490-rpc-0.8.0' of https://github.com/fou…
ce77091 
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
@franciszekjob
Merge branch 'franciszekjob/2490-rpc-0.8.0' of https://github.com/fou…
f0467b0 
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
@franciszekjob
Merge branch 'franciszekjob/2490-rpc-0.8.0' of https://github.com/fou…
c3d6a4a 
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
@franciszekjob
Add todos
470116e
@franciszekjob
Merge branch 'franciszekjob/2490-rpc-0.8.0' of https://github.com/fou…
f6d479b 
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
@franciszekjob
Merge branch 'franciszekjob/2490-rpc-0.8.0' of https://github.com/fou…
bf482bc 
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
@franciszekjob
Update changelog
210421b
@franciszekjob
Fix test_wrong_calldata
f840464
@franciszekjob
Fix test_wrong_function_name
f2e3a8e
@franciszekjob
Add todo
5324b2a
@franciszekjob
Merge branch 'franciszekjob/2490-rpc-0.8.0' of https://github.com/fou…
11b9877 
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
@franciszekjob
Merge branch 'franciszekjob/2490-rpc-0.8.0' of https://github.com/fou…
515995a 
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
@franciszekjob
Merge branch 'franciszekjob/2490-rpc-0.8.0' of https://github.com/fou…
f7188ec 
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
@franciszekjob
Remove docs snippets fix
4f08b2c
@franciszekjob
Merge branch 'franciszekjob/2490-rpc-0.8.0' of https://github.com/fou…
47b68e1 
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
@franciszekjob
Merge branch 'franciszekjob/2490-rpc-0.8.0' into franciszekjob/2490-2…
7b7500b 
…-fix-sncast-scripts
@cptartur @franciszekjob
Fix cast script errors (#3099)
da757eb 
<!-- Reference any GitHub issues resolved by this PR -->

Related #3091

## Introduced changes

<!-- A brief description of the changes -->

- Resolved all issues with tests except for
`test_insufficient_account_balance`

## Checklist

<!-- Make sure all of these are complete -->

- [ ] Linked relevant issue
- [ ] Updated relevant documentation
- [ ] Added relevant tests
- [ ] Performed self-review of the code
- [ ] Added changes to `CHANGELOG.md`

---------

Co-authored-by: Franciszek Job <[email protected]>
@franciszekjob
Merge branch 'franciszekjob/2490-rpc-0.8.0' of https://github.com/fou…
e4e3093 
…ndry-rs/starknet-foundry into franciszekjob/2490-2-fix-sncast-scripts
@franciszekjob franciszekjob marked this pull request as ready for review March 19, 2025 12:21
@franciszekjob franciszekjob requested a review from a team as a code owner March 19, 2025 12:21
@franciszekjob franciszekjob requested review from ddoktorski and kkawula and removed request for a team March 19, 2025 12:21
@franciszekjob
Copy link
Contributor Author

franciszekjob commented Mar 20, 2025 •
edited
Loading

Example attempt of account creation with type braavos:

image

Base automatically changed from franciszekjob/2490-2-fix-sncast-scripts to franciszekjob/2490-rpc-0.8.0 March 25, 2025 09:29
@franciszekjob franciszekjob merged commit 6cb824a into franciszekjob/2490-rpc-0.8.0 Mar 25, 2025
@franciszekjob franciszekjob deleted the franciszekjob/2490-disable-braavos branch March 25, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddoktorski ddoktorski ddoktorski approved these changes

@kkawula kkawula kkawula approved these changes

@cptartur cptartur Awaiting requested review from cptartur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@franciszekjob @ddoktorski @kkawula @cptartur