Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Replace deprecated #[clap] attributes with #[arg]/#[command] #3128

Merged
merged 1 commit into from
Mar 25, 2025
Merged

fix: Replace deprecated #[clap] attributes with #[arg]/#[command] #3128

merged 1 commit into from
Mar 25, 2025

Conversation

Himess
Copy link
Contributor

@Himess Himess commented Mar 21, 2025

Closes #3127

Introduced changes

This PR updates deprecated #[clap(...)] attributes to their modern equivalents in clap 4.x.
The current codebase still uses outdated syntax that has been deprecated since version 4.0.
By making this update, we ensure compatibility with future versions and maintain code quality.

Tests

cargo check --features clap/deprecated fixed now.

Pasted Graphic 74

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@Himess Himess requested a review from a team as a code owner March 21, 2025 02:14
@Himess Himess requested review from franciszekjob and kkawula March 21, 2025 02:14
franciszekjob
franciszekjob approved these changes Mar 23, 2025
View reviewed changes
Copy link
Contributor

@franciszekjob franciszekjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution @Himess 👐 !

@Himess
Copy link
Contributor Author

Himess commented Mar 23, 2025

You're welcome! Glad to help. 🙌 @franciszekjob

@cptartur cptartur added this pull request to the merge queue Mar 25, 2025
@cptartur cptartur mentioned this pull request Mar 25, 2025
Merged
5 tasks
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 25, 2025
@Himess
Copy link
Contributor Author

Himess commented Mar 25, 2025

Hi @cptartur . Do I need to take any action? It’s been removed from the merge queue.

@kkawula kkawula added this pull request to the merge queue Mar 25, 2025
Merged via the queue into foundry-rs:master with commit 6bb6247 Mar 25, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cptartur cptartur cptartur approved these changes

@franciszekjob franciszekjob franciszekjob approved these changes

@kkawula kkawula kkawula approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecated #[clap(...)] attributes causing warnings/errors
4 participants
@Himess @cptartur @franciszekjob @kkawula