refactor(sncast) Introduce accounts repository - #4549
Open
integraledelebesgue wants to merge 1 commit into
Open
Conversation
integraledelebesgue
force-pushed
the
refactor/sncast-accounts-repository
branch
4 times, most recently
from
August 20, 2026 15:12
9aba5fd to
a84dbf7
Compare
integraledelebesgue
marked this pull request as ready for review
August 20, 2026 15:25
integraledelebesgue
requested review from
MKowalski8,
ddoktorski and
franciszekjob
and removed request for
MKowalski8
August 20, 2026 15:25
integraledelebesgue
changed the title
franciszekjob
left a comment
franciszekjob
left a comment
Contributor
There was a problem hiding this comment.
One remark about migration: could we model it more generically (for potential future schema migrations) instead of coupling it specifically to v1 -> latest?
integraledelebesgue
force-pushed
the
refactor/sncast-accounts-repository
branch
from
August 24, 2026 10:04
b0089fd to
8899f7d
Compare
ddoktorski
requested changes
Aug 24, 2026
| { | ||
| "version": 2, | ||
| "accounts": { | ||
| "alpha-sepolia": { |
Contributor
There was a problem hiding this comment.
What about replacing network names in V2 with just chain ids instead of strange alpha-sepolia etc.?
integraledelebesgue
force-pushed
the
refactor/sncast-accounts-repository
branch
from
August 25, 2026 10:15
8899f7d to
324d245
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-accounts-repository
branch
2 times, most recently
from
August 25, 2026 10:55
c17b6d5 to
2b7bd6b
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-accounts-repository
branch
from
August 26, 2026 10:50
2b7bd6b to
6ced4c4
Compare
5 tasks
integraledelebesgue
force-pushed
the
refactor/sncast-accounts-repository
branch
from
August 26, 2026 11:23
6ced4c4 to
131b528
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-accounts-repository
branch
from
August 27, 2026 10:23
0483727 to
1ebff2f
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-accounts-repository
branch
from
August 27, 2026 11:01
1ebff2f to
466c75b
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-accounts-repository
branch
from
August 27, 2026 17:11
466c75b to
139cd08
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-accounts-repository
branch
from
August 28, 2026 15:04
139cd08 to
f4f8f3c
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-accounts-repository
branch
2 times, most recently
from
August 28, 2026 15:16
456142b to
d6cb107
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-accounts-repository
branch
2 times, most recently
from
August 28, 2026 15:49
69a8a83 to
34a036d
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-accounts-repository
branch
3 times, most recently
from
August 28, 2026 17:16
c67843b to
d47015e
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-accounts-repository
branch
2 times, most recently
from
August 31, 2026 13:08
d47015e to
66a75c3
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-accounts-repository
branch
from
September 1, 2026 10:54
66a75c3 to
04c818c
Compare
ddoktorski
requested changes
Sep 1, 2026
ddoktorski
left a comment
ddoktorski
left a comment
Contributor
There was a problem hiding this comment.
PR title seems inaccurate, it is not only refactor as it introduces account migrate command
| AccountsFile, | ||
| TemporaryAccountsFile, | ||
| Backup, | ||
| ParentDirectory, |
Contributor
There was a problem hiding this comment.
Why is it a variant of FileType?
Contributor
Author
There was a problem hiding this comment.
It simplifies the construction of errors related to files. We don't need to repeat a nearly identical message for every type of file that may produce a given kind of error
| sync_parent(parent, path) | ||
| } | ||
|
|
||
| fn with_exclusive_lock<T>( |
Contributor
There was a problem hiding this comment.
Can we simplify the code so this function only locks and returns File? (can be renamed to lock_exclusive)
Contributor
Author
There was a problem hiding this comment.
I think the current implementation is optimal. Returning a plain File is not possible because it needs to be unlocked after performing the operation anyway. We could wrap it with a guard with custom Drop, but it will be a more complex solution than this.
integraledelebesgue
force-pushed
the
refactor/sncast-accounts-repository
branch
from
September 2, 2026 10:48
04c818c to
83b8799
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-accounts-repository
branch
from
September 2, 2026 14:02
83b8799 to
07b7ed9
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-accounts-repository
branch
from
September 3, 2026 19:06
07b7ed9 to
8dbb13b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced changes
This PR introduces the
AccountRepository- a layer between the physical storage of accounts and their corresponding schema-agnostic representations which abstracts filesystem operations from code that reads/modifies the accounts.It is used later in the stack.
Checklist
CHANGELOG.md