[#7259] Support typed custom flags for Active Effect conditions - #7260
Open
thatlonelybugbear wants to merge 1 commit into
Open
[#7259] Support typed custom flags for Active Effect conditions#7260thatlonelybugbear wants to merge 1 commit into
thatlonelybugbear wants to merge 1 commit into
Conversation
thatlonelybugbear
marked this pull request as draft
July 16, 2026 01:49
Contributor
|
If I understand this proposal right, it requires using flags.dnd5e. But then you may as well register a new character flag in which case it is already cast to the right type. |
Contributor
Author
Yep, that makes sense for flags we already know about. The only reason for this would be when the final ID is user-defined, so there is nothing concrete to register in characterFlags ahead of time |
thatlonelybugbear
marked this pull request as ready for review
July 16, 2026 03:16
Fyorl
added
feature request
api
system: active effects
strategic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress!
I was thinking of something along these lines
Closes #7259