[#3011] Allow @item use in effect values, move custom _checkCondition into core shouldApplyChange - #7366
Merged
Merged
Conversation
roth-michael
force-pushed
the
use-item-data
branch
from
August 21, 2026 19:14
7dd0ae9 to
9cc89cf
Compare
roth-michael
marked this pull request as ready for review
August 21, 2026 19:20
arbron
requested changes
Aug 24, 2026
arbron
approved these changes
Aug 24, 2026
Collaborator
|
Added the |
- Remove unnecessary find() - Fix indiscriminate baseData copy - Fix enchantment conditions not being evaluated
Fyorl
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3011
The changes to
ActiveEffect5eare self-explanatory. Other piece is that I moved the call ofprepareFinalAttributeson embedded items &_prepareSpellcastingfromActor5e#prepareDatainto the "final" phase inActor5e#applyActiveEffects, so that resulting values can actually be modified byfinal-phase AE changes.Follow-up improvement of this (specifically, being able to use
@item.uses.value) in #7368.