Skip to content

fix: Valid handler #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jimyag merged 2 commits into from
Jun 25, 2025
Merged

fix: Valid handler #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bda03ef
Allow interface type as valid handler parameter
miclle Jun 25, 2025
e8af1bc
Add test case for handler with interface parameter
miclle Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ func IsValidHandlerFunc(handler HandlerFunc) bool {
secondParam = secondParam.Elem()
}
// Check if it's a struct or map type
if secondParam.Kind() != reflect.Struct && secondParam.Kind() != reflect.Map {
if secondParam.Kind() != reflect.Struct && secondParam.Kind() != reflect.Map && secondParam.Kind() != reflect.Interface {
return false
}
}
Expand Down
5 changes: 5 additions & 0 deletions engine_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,11 @@ func TestIsValidHandlerFunc(t *testing.T) {
handler: func(ctx *fox.Context, args map[string]any) ([]byte, *HTTPError) { return nil, nil },
expected: true,
},
{
name: "HTTP error with interface parameter",
handler: func(ctx *fox.Context, args any) ([]byte, *HTTPError) { return nil, nil },
expected: true,
},
{
name: "Non-error second return type",
handler: func(ctx *fox.Context) (string, string) { return "", "" },
Expand Down