Skip to content

Enable reading job annotations for the migrate job again #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spewu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable reading job annotations for the migrate job again #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/migrate/templates/job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ kind: Job
metadata:
name: {{ include "convoy-migrate.fullname" . }}
annotations:
{{- toYaml .Values.jobAnnotations | nindent 4 }}
"helm.sh/hook": post-install,post-upgrade
"helm.sh/hook-weight": "0"
"helm.sh/hook-delete-policy": before-hook-creation
Expand Down
1 change: 1 addition & 0 deletions values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,7 @@ server:


migrate:
jobAnnotations: {}
image:
# -- Repository to be used by to migrate. The latest tag is used by default. It will install before any other services.
repository: *image
Expand Down