Forward TARTELET_RUN_OPTIONS to tart as separate arguments - #135
Open
DDRBoxman wants to merge 1 commit into
Open
Forward TARTELET_RUN_OPTIONS to tart as separate arguments#135DDRBoxman wants to merge 1 commit into
DDRBoxman wants to merge 1 commit into
Conversation
TARTELET_RUN_OPTIONS was appended to `tart run` as a single argv element, so any value with more than one flag was rejected as one unknown option — e.g. softnet network isolation (`--net-softnet --net-softnet-allow=<subnet>`) failed with `Unknown option '--net-softnet --net-softnet-allow=...'`. The value is now shell-tokenized into separate arguments via a small POSIX-style splitter that honors single/double quotes and backslash escapes, so a quoted value (such as a `--dir=` mount whose path contains spaces) is preserved instead of being split on every space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TARTELET_RUN_OPTIONS was appended to
tart runas a single argv element, so any value with more than one flag was rejected as one unknown optionThe value is now shell-tokenized into separate arguments via a small POSIX-style splitter that honors single/double quotes and backslash escapes, so a quoted value (such as a
--dir=mount whose path contains spaces) is preserved instead of being split on every space.Motivation and Context
It was not possible to enable softnet network isolation eg. (
--net-softnet --net-softnet-allow=<subnet>) failed withUnknown option '--net-softnet --net-softnet-allow=...'.Screenshots (if appropriate):
Types of changes