Skip to content

refactor(projects)!: remove is_active field and update status options - #57984

Open
Sudharsanan11 wants to merge 4 commits into
frappe:developfrom
aerele:disabled__status
Open

refactor(projects)!: remove is_active field and update status options#57984
Sudharsanan11 wants to merge 4 commits into
frappe:developfrom
aerele:disabled__status

Conversation

@Sudharsanan11

@Sudharsanan11 Sudharsanan11 commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Issue:
Project carries both an "Is Active" (Yes/No) select and a "Status" select, which overlap and let a project be Status = Open while Is Active = No.

Nothing in ERPNext reads Project.is_active: it is never written by any code path, it does not filter the Project link search (erpnext/controllers/queries.py, get_project_name), and it does not block tasks, timesheets or billing. The only places it appears are the list view fields and the Project Summary report filter, so marking a project inactive changes nothing except that label.

Proposal: drop the is_active field and add "Disabled" to the Status options, so a single field expresses the project state, with a patch migrating is_active = "No" projects that are Open or On hold to status "Disabled".

Before:
image

After:
image

Backport Needed for v15 & v16

@Sudharsanan11

Copy link
Copy Markdown
Collaborator Author

Raising this PR on behalf of @Poovetha

@github-actions github-actions Bot added the skip-release-notes This PR should not be mentioned in the release notes label Aug 10, 2026
@Poovetha
Poovetha force-pushed the disabled__status branch 2 times, most recently from e44c947 to 4c9d360 Compare August 10, 2026 15:30
@Sudharsanan11
Sudharsanan11 marked this pull request as ready for review August 10, 2026 16:59
@mergify

mergify Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@greptile-apps

greptile-apps Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the previously reported explicit transaction commit is absent, and the patch runner retains atomic commit and rollback ownership.

Reviews (3): Last reviewed commit: "Merge branch 'develop' into disabled__st..." | Re-trigger Greptile

Comment thread erpnext/patches/v16_0/migrate_project_is_active_to_status.py Outdated
@Sudharsanan11
Sudharsanan11 marked this pull request as draft August 10, 2026 17:06
@Sudharsanan11
Sudharsanan11 marked this pull request as ready for review August 10, 2026 17:30
@diptanilsaha diptanilsaha changed the title refactor(projects): remove is_active field and update status options refactor(projects)!: remove is_active field and update status options Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport version-15-hotfix backport version-16-hotfix skip-release-notes This PR should not be mentioned in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants