refactor(projects)!: remove is_active field and update status options - #57984
Open
Sudharsanan11 wants to merge 4 commits into
Open
refactor(projects)!: remove is_active field and update status options#57984Sudharsanan11 wants to merge 4 commits into
Sudharsanan11 wants to merge 4 commits into
Conversation
Collaborator
Author
|
Raising this PR on behalf of @Poovetha |
Poovetha
force-pushed
the
disabled__status
branch
2 times, most recently
from
August 10, 2026 15:30
e44c947 to
4c9d360
Compare
Sudharsanan11
marked this pull request as ready for review
August 10, 2026 16:59
Sudharsanan11
requested review from
mihir-kandoi,
nishkagosalia,
rohitwaghchaure and
ruthra-kumar
as code owners
August 10, 2026 16:59
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Contributor
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported explicit transaction commit is absent, and the patch runner retains atomic commit and rollback ownership. Reviews (3): Last reviewed commit: "Merge branch 'develop' into disabled__st..." | Re-trigger Greptile |
Sudharsanan11
marked this pull request as draft
August 10, 2026 17:06
Poovetha
force-pushed
the
disabled__status
branch
from
August 10, 2026 17:09
4c9d360 to
075dbf8
Compare
Poovetha
force-pushed
the
disabled__status
branch
from
August 10, 2026 17:17
075dbf8 to
8dc872c
Compare
Sudharsanan11
marked this pull request as ready for review
August 10, 2026 17:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Project carries both an "Is Active" (Yes/No) select and a "Status" select, which overlap and let a project be Status = Open while Is Active = No.
Nothing in ERPNext reads Project.is_active: it is never written by any code path, it does not filter the Project link search (erpnext/controllers/queries.py, get_project_name), and it does not block tasks, timesheets or billing. The only places it appears are the list view fields and the Project Summary report filter, so marking a project inactive changes nothing except that label.
Proposal: drop the is_active field and add "Disabled" to the Status options, so a single field expresses the project state, with a patch migrating is_active = "No" projects that are Open or On hold to status "Disabled".
Before:

After:

Backport Needed for v15 & v16