-
Notifications
You must be signed in to change notification settings - Fork 71
feat: move absolute/fixed positioned freely on the canvas #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thanks for the PR
The updates look janky if directly done on the studio component. That's why there is a ComponentEditor in place that overlays the studio component for operations.
Can you replicate the handleMove function & related functionality from Frappe Builder here because the usage is similar:
https://github.com/frappe/builder/blob/34e0ae2b39c9209e6bbbe6b4a76ff40815d32157/frontend/src/components/BlockEditor.vue#L252-L307
Also, you seem to have changed the yarn.lock significantly. Since there are no dependency changes in this PR, can you leave it out?
33d482e to
32ab7bb
Compare
32ab7bb to
4810dd9
Compare
|
@ruchamahabal I have made the changes as you suggested. |
4810dd9 to
2f348fb
Compare
|
@shreyashrpawar any updates on this feature ?, can i contribute to it |
|
@Simoh8 The contribution has been made with the mentioned suggestions. Waiting to be merged. |
|
@shreyashrpawar Okay cool |
I have opened the issue recently. Issue: #139
Previously, we had to manually change the positioning values from the right panel. But, now you can also do that by dragging the elements to the new position.
Screencast.from.2025-12-16.12-51-40.mp4