feat(two-way binding): Sync any prop with variable, not just modelValue #149
+144
−166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntext - eg: v-modeling dataItem.doctype
- renderer could have changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync with variable option was only available for modelValue prop
To understand what two-way binding is: Here, basically, whenever you check “Fetch members from multiple sources” it will set
newAudience.fetch_from_other_doctypesvariable totrue. Moreover, if you setnewAudience.fetch_from_other_doctypesto false anywhere in your code, the “Fetch members from multiple sources” checkbox will be unchecked. So this “sync” is now available for any prop, not just modelValue.Also fixed an issue where sync with variable didn't work for repeater context/component context
4800ebe
So here, the value of the Link field inside a repeater can be synced with the data item at that index