-
Notifications
You must be signed in to change notification settings - Fork 269
feat: setup translatable frontend for V2 #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
flaviacastro
wants to merge
5
commits into
frappe:master
Choose a base branch
from
flaviacastro:feat/setup-translatable-frontend-for-V2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+277
−173
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e200089
feat: setup translatable frontend for V2
flaviacastro 2ec6a94
chore: format JS files using prettier
flaviacastro b035c7e
chore: minor improvements considering nitpick comments from coderabbit
flaviacastro cc0065f
fix: context variable assignment
flaviacastro 73ffedd
fix: jinja2 exception at web_sidebar template
flaviacastro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import frappe | ||
| from frappe.translate import get_all_translations | ||
|
|
||
|
|
||
| @frappe.whitelist(allow_guest=True) | ||
| def get_translations(): | ||
| if frappe.session.user != "Guest": | ||
| language = frappe.db.get_value("User", frappe.session.user, "language") | ||
| else: | ||
| language = frappe.db.get_single_value("System Settings", "language") | ||
|
|
||
| return get_all_translations(language) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| export { translate as __ }; | ||
| if (!globalThis.translatedMessages) fetchTranslations(); | ||
| globalThis.__ = translate; | ||
flaviacastro marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| function format(message, replace) { | ||
| return message.replace(/{(\d+)}/g, (match, number) => | ||
| replace[number] === undefined ? match : replace[number], | ||
| ); | ||
| } | ||
|
|
||
| function translate(message, replace, context = null) { | ||
| const translatedMessages = globalThis.translatedMessages || {}; | ||
| let translatedMessage = ""; | ||
|
|
||
| if (context) { | ||
| const key = `${message}:${context}`; | ||
| if (translatedMessages[key]) { | ||
| translatedMessage = translatedMessages[key]; | ||
| } | ||
| } | ||
|
|
||
| if (!translatedMessage) { | ||
| translatedMessage = translatedMessages[message] || message; | ||
| } | ||
|
|
||
| const hasPlaceholders = /{\d+}/.test(message); | ||
| if (!hasPlaceholders) { | ||
| return translatedMessage; | ||
| } | ||
|
|
||
| return format(translatedMessage, replace); | ||
| } | ||
|
|
||
| function fetchTranslations() { | ||
| fetch("/api/method/wiki.api.get_translations") | ||
| .then((response) => response.json()) | ||
| .then((data) => { | ||
| globalThis.translatedMessages = data.message; | ||
| }); | ||
| } | ||
coderabbitai[bot] marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| import "./translation.js"; | ||
| import "./wiki"; | ||
| import "./render_wiki"; | ||
| import "./editor"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.