Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add newspaper layout with CSS Grid and user stories #676

Merged

Conversation

zairahira
Copy link
Member

Checklist:

Closes #670

@zairahira zairahira added the Labs Team This work is for the labs team only label Jan 21, 2025
Copy link
Contributor

@Dario-DC Dario-DC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prototype is looking good @zairahira
I would use more semantic elements though:

  • a main for .newspaper-layout
  • we need an h1 for the .title
  • section elements in place of the other article divs
  • and a figure for the .cover-image

@zairahira zairahira requested a review from Dario-DC February 18, 2025 09:35
Copy link
Contributor

@Dario-DC Dario-DC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should ask to include an h2 and a p within feature-article since an h3 and a p are required for the smaller articles. And now that I think about it, maybe article elements are more appropriate than section elements 🤔 After that I think we can merge this.

@zairahira
Copy link
Member Author

@Dario-DC,

I have added another story for the content of .news-article:

4. The `.news-article` should include an `h2` element for the article title and a `p` element for the article content.

I have also updated the section elements to article both in the html and userstories.

@zairahira zairahira requested a review from Dario-DC February 21, 2025 17:36
Copy link
Contributor

@Dario-DC Dario-DC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Co-authored-by: Dario-DC <[email protected]>
@jdwilkin4 jdwilkin4 merged commit 88a6221 into freeCodeCamp:main Feb 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor magazine lab to newspaper lab
3 participants