-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add newspaper layout with CSS Grid and user stories #676
chore: add newspaper layout with CSS Grid and user stories #676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The prototype is looking good @zairahira
I would use more semantic elements though:
- a
main
for.newspaper-layout
- we need an
h1
for the.title
section
elements in place of the other articlediv
s- and a
figure
for the.cover-image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should ask to include an h2
and a p
within feature-article
since an h3
and a p
are required for the smaller articles. And now that I think about it, maybe article
elements are more appropriate than section
elements 🤔 After that I think we can merge this.
I have added another story for the content of 4. The `.news-article` should include an `h2` element for the article title and a `p` element for the article content. I have also updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
fullstack-cert/css-projects/newspaper-css-grid-lab/userstories.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Dario-DC <[email protected]>
Checklist:
Update index.md
)Closes #670