-
Notifications
You must be signed in to change notification settings - Fork 235
WIP: Enable AD trust tests #1339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rjeffman
wants to merge
22
commits into
freeipa:master
Choose a base branch
from
rjeffman:enable_ad_trust_tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
039e2aa to
8028268
Compare
Member
Author
|
/azp run chekpr |
|
No pipelines are associated with this pull request. |
623629a to
47efbcf
Compare
Using pipes and redirections is ansible.builtin.shell allows the occurence of pipe errors and makes the scripts more dificult to read, as there's more 'boilerpart code' that is not nedded. By using 'stdin' argument to this scripts the scripts bome easier to read and to adapt to different values. Signed-off-by: Rafael Guterres Jeffman <[email protected]>
Signed-off-by: Rafael Guterres Jeffman <[email protected]>
Signed-off-by: Rafael Guterres Jeffman <[email protected]>
Some tests require AD trust and some common variables related to the domain controller and AD users. This patch modifies the tests that require these tasks and vars to use the same sources. With this change configuring the variables with inventory files is easier and ensures that data used is valid. Signed-off-by: Rafael Guterres Jeffman <[email protected]>
Without a dnsforwardzone to the AD DC node setting the trust might fail. Signed-off-by: Rafael Guterres Jeffman <[email protected]>
ipalab-config allows the creation of complex IPA environments using rootless containers. For example, the tool provides the means to create an environment where a trust can be set between IPA and Samba AD DC, which is similar enough to Windows AD DC to be used in ansible-freeipa testing. To start a test scenario run 'infra/scenarios/start-scenario' passing the scenario configuration as parameter. The configuration for the scenario will be generated with 'ipalab-config', the containers will be started, all the nodes will be deployed and the initial configuration will be applied to the scenario. The configuration directory will be moved to the repository root. Only one scenario can be run at a single time. When the tests are finished, 'infra/scenarios/stop-scenario' will cleanup the environment, and a new scenario can be started. The configuration directory created will not be removed, in this case, but will be overwritten if a new scenario is created. Signed-off-by: Rafael Guterres Jeffman <[email protected]>
Signed-off-by: Rafael Guterres Jeffman <[email protected]>
Signed-off-by: Rafael Guterres Jeffman <[email protected]>
6d23c24 to
1bd71f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress to enable upstream tests that require that an AD trust is available.