Fix easy baseline errors (1/?) by MorganBennetDev · Pull Request #8081 · freelawproject/courtlistener

MorganBennetDev · 2026-10-02T18:06:29Z

Fixes

Decreases baseline type errors from 1,294->1,029.

Summary

Shuffles around some dict initializations and adds TypedDicts to avoid various errors caused by improperly inferred types for dicts and items
Adds overload to find_docket_object so it's correctly typed
Changes FederalCourtsQuerySet and StateCourtsQuerySet to Managers since that's how they were being used anyway
Adds method to cordon off as_str_type in cl/search/forms.py

Deployment

This PR should:

AI Disclosure

No AI tools were used to create the content of this PR.
Parts of this PR were created with the help of an AI tool, and I have carefully reviewed all of its content and take full responsibility for it.

MorganBennetDev · 2026-10-02T18:44:41Z

but one new error from its own change was baselined instead of fixed, violating CLAUDE.md's MUST NOT rule on baselining errors in changed code.

Seeing as I am not Claude.................

cweider

Some of these changes are more involved than others! Here are initial comments on the straight-forward ones.

- Add all non-test modules to type checking - Update baseline - Update CLAUDE.md with new guidance

search/forms.py

`FederalCourtsQuerySet` and `StateCourtQuerySet` were only used once by calling the `as_manager` method, which erased their methods from pyrefly. Just make them managers to fix a bunch of errors

cl.corpus_importer.import_columbia That was certainly an experience

Mostly move things around to eliminate unnecessary `MutableMapping.update` calls. Also add some `TypedDict`s where they help.

`AudioTranscriptionMetadata` save

MorganBennetDev · 2026-10-06T22:56:27Z

@cweider Addressed your pagination comment and got confirmation from the team that the Columbia import stuff can just be deleted so no need to mess around.

cweider

Just a few things to doublecheck. If they don’t need revising, then this is good to go.

cweider · 2026-10-07T00:37:10Z

+
+    def all_pacer_courts(self) -> "models.QuerySet[Court]":
+        return (
+            self.get_queryset()


All others use super().get_queryset() Is this intentional? I worry that the super/self distinction is setting things up for trouble down the line. If intentional, probably worth a comment.

I wonder if it’s done for optimization? I suspect that it’s probably not optimizing much. But this is only my take from reading – it’s gotten less attention from me than it has from you.

There's a minimized Claude review earlier in the PR that brings up the reason why I switched the others to use super(). Originally I had everything using self and just didn't bother to change this one when fixing the other methods.

cweider · 2026-10-07T00:42:15Z

-                    Court.FEDERAL_BANKRUPTCY,
-                    Court.FEDERAL_APPELLATE,
-                ]
+class FederalCourtsManager(models.Manager):


Considered models.Manager["Court"]?

In light of the other QuerySet subclasses, I wonder if, perhaps, the problem with the base implementation was the unspecified the generic for models.QuerySet. If done, Self could be used for all of the method return types and it would cut down substantially on the wordiness.

I don’t feel qualified to speak on which is better, a subclass of Manager or QuerySet - do whatever makes sense.

Pyrefly currently erases extra methods when you call QuerySet.as_manager, which is what this was trying to solve.

cweider · 2026-10-07T00:43:01Z

-                    Court.FEDERAL_APPELLATE,
-                ]
+class FederalCourtsManager(models.Manager):
+    def get_queryset(self) -> "models.QuerySet[Court]":


Perhaps models.QuerySet["Court"] (quotes in the generic). I think this is purely aesthetic tho.

cweider · 2026-10-07T01:05:45Z

        verbose_name_plural = "Courthouses"


 class ClusterCitationQuerySet(models.query.QuerySet):


It might be good to give ClusterCitationQuerySet the same treatment as FederalCourtsQuerySet.

cweider · 2026-10-07T01:06:51Z

 ]


 class OpinionQuerySet(models.QuerySet):


It might be good to give OpinionQuerySet the same treatment as FederalCourtsQuerySet.

cweider · 2026-10-07T01:11:36Z

-                    Court.FEDERAL_BANKRUPTCY,
-                    Court.FEDERAL_APPELLATE,
-                ]
+class FederalCourtsManager(models.Manager):


In light of the other QuerySet subclasses, I wonder if, perhaps, the problem with the base implementation was the unspecified the generic for models.QuerySet. If done, Self could be used for all of the method return types and it would cut down substantially on the wordiness.

I don’t feel qualified to speak on which is better, a subclass of Manager or QuerySet - do whatever makes sense.

managers

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

MorganBennetDev · 2026-10-07T19:45:05Z

@cweider Gave it a second thought and decided to leave the QuerySet->Manager changes out of this one and just wait for proper support upstream.

cweider

Setting aside import_columbia, the change pretty small. I take it on faith that .pyrefly-baseline.json large additive bit is an artifact of wonky diffing and that it’s not a symptom of any new issues being introduced.

MorganBennetDev added this to the 100% Type Coverage milestone Oct 2, 2026

MorganBennetDev self-assigned this Oct 2, 2026

MorganBennetDev added this to Sprint (Web Team) Oct 2, 2026

This comment was marked as resolved.

Sign in to view

cweider reviewed Oct 2, 2026

View reviewed changes

Comment thread cl/corpus_importer/import_columbia/parse_opinions.py Outdated

MorganBennetDev force-pushed the morgan/ci-typeck-include-more branch from e3e5bd5 to 08f19c4 Compare October 6, 2026 18:54

Base automatically changed from morgan/ci-typeck-include-more to main October 6, 2026 19:51

MorganBennetDev added 9 commits October 6, 2026 15:20

chore(types): Just check everything

bfb245a

- Add all non-test modules to type checking - Update baseline - Update CLAUDE.md with new guidance

chore(types): Baseline update

0e3b689

fix(types): Use overload to correctly type find_docket_object

0cabd6c

fix(types): missing-attribute caused by field blending in

22f1831

search/forms.py

fix(types): Manager missing-attribute errors

c2a5999

`FederalCourtsQuerySet` and `StateCourtQuerySet` were only used once by calling the `as_manager` method, which erased their methods from pyrefly. Just make them managers to fix a bunch of errors

fix(types): Used TypedDict to fix errors in

8c2954d

cl.corpus_importer.import_columbia That was certainly an experience

fix(types): Most no-matching-overload errors

c7ed95f

Mostly move things around to eliminate unnecessary `MutableMapping.update` calls. Also add some `TypedDict`s where they help.

fix(types): Undo breaking FederalCourtsManager and

6f2f086

`AudioTranscriptionMetadata` save

chore(types): Post-rebase baseline update

b879211

MorganBennetDev force-pushed the morgan/ci-typeck-fixes-2 branch from d2a61ed to b879211 Compare October 6, 2026 21:21

MorganBennetDev added 3 commits October 6, 2026 16:31

chore(corpus_importer): Delete unused command and module

3b59e20

chore(types): Address review comment

8cb2a3f

fix(audio): Failing test

2736317

cweider approved these changes Oct 7, 2026

View reviewed changes

cweider reviewed Oct 7, 2026

View reviewed changes

MorganBennetDev and others added 5 commits October 7, 2026 13:12

chore(types): Move ClusterCitation and Opinion from query sets to

376bc01

managers

Merge branch 'main' into morgan/ci-typeck-fixes-2

d054eed

fix(types): Bad baseline merge

f66c692

revert(types): Restore ClusterCitation and Opinion query sets

d1a9ff4

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

revert(types): Restore FederalCourts and StateCourts query sets

f6be5e8

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

cweider approved these changes Oct 7, 2026

View reviewed changes

Merge branch 'main' into morgan/ci-typeck-fixes-2

808ed9c

albertisfu approved these changes Oct 8, 2026

View reviewed changes

albertisfu added the skip-deploy label Oct 8, 2026

albertisfu enabled auto-merge October 8, 2026 15:30

MorganBennetDev disabled auto-merge October 8, 2026 15:43

MorganBennetDev merged commit 081919e into main Oct 8, 2026
9 checks passed

MorganBennetDev deleted the morgan/ci-typeck-fixes-2 branch October 8, 2026 15:43

		verbose_name_plural = "Courthouses"


		class ClusterCitationQuerySet(models.query.QuerySet):

Conversation

MorganBennetDev commented Oct 2, 2026

Fixes

Summary

Deployment

AI Disclosure

Uh oh!

This comment was marked as resolved.

Uh oh!

MorganBennetDev commented Oct 2, 2026

Uh oh!

cweider left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MorganBennetDev commented Oct 6, 2026

Uh oh!

cweider left a comment

Choose a reason for hiding this comment

Uh oh!

cweider Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

MorganBennetDev Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

cweider Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

cweider Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MorganBennetDev Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

cweider Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

cweider Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

cweider Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

cweider Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MorganBennetDev commented Oct 7, 2026

Uh oh!

cweider left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cweider Oct 7, 2026 •

edited

Loading

cweider Oct 7, 2026 •

edited

Loading

cweider left a comment •

edited

Loading