This repository was archived by the owner on Dec 4, 2018. It is now read-only.
FIX: Make node-bitcoin compatable with browserify#22
Closed
brandonrobertz wants to merge 1 commit intofreewil:masterfrom
brandonrobertz:master
Closed
FIX: Make node-bitcoin compatable with browserify#22brandonrobertz wants to merge 1 commit intofreewil:masterfrom brandonrobertz:master
brandonrobertz wants to merge 1 commit intofreewil:masterfrom
brandonrobertz:master
Conversation
Owner
|
wouldn't a better solution be to send a pull request to http-browserify? |
Author
|
That would be cleaner on this end. I guess I can give that a shot first if you'd prefer. But with 25 open pull requests and an existing issue about setTimeout from 8 months ago with zero comments, I'm not sure how far I'll get. |
Author
|
I commented on browserify/http-browserify#49 to see there's any interest in a fix for this upstream. |
|
@freewil it would be cleaner. Alternatively you could use https://github.com/scottcorgan/httpify, a shim for |
Author
|
I'm going to close this ticket and focus on patching http-browserify. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have some isomorphic JS that currently uses node-bitcoin. It works beautifully inside node. When I browserify it, the replacement
httpmodule that provides therequestobject, doesn't have asetTimeoutmethod, which causes a crash. This is a simple two-line fix that allows this library to work in the browser, as well.