Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for deploy percentage #83

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Add support for deploy percentage #83

merged 4 commits into from
Jun 11, 2024

Conversation

remdash
Copy link
Contributor

@remdash remdash commented Jun 10, 2024

Following discussion in fregante/chrome-webstore-upload#91 (comment) here is an update of the CLI

Copy link
Owner

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

readme.md Outdated
@@ -42,6 +42,7 @@ $ chrome-webstore-upload --help
--refresh-token OAuth2 Refresh Token (environment variable REFRESH_TOKEN)
--auto-publish Can be used with the "upload" command (deprecated, use `chrome-webstore-upload` without a command instead)
--trusted-testers Can be used with the "publish" command
--deploy-percentage Can be used with the "publish" command
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs an example or a default, like

Suggested change
--deploy-percentage Can be used with the "publish" command
--deploy-percentage Can be used with the "publish" command. Defaults to 100

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also in the actual CLI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fixed there too.

@fregante fregante changed the title chore(publish): update publish command with deploy percentage parameter Add support for deploy percentage Jun 10, 2024
@fregante fregante merged commit d8de0c3 into fregante:main Jun 11, 2024
2 checks passed
@fregante
Copy link
Owner

fregante commented Jun 11, 2024

3.3.0 is out 🙌

Let me know how it works in the field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants