Bump to C++17

[kaixoo12]

Bumping the C++ version is useful because while it allows you to make new code more readable, all compatibility is kept with older versions. Ergo, bumping doesn't hurt at all.

**I couldn't find where the standard was set before. So I set it in the root CMakeLists.txt. Please tell me where you had it set before @rodlie **

[rodlie]

https://github.com/friction2d/friction/blob/main/src/cmake/friction-common.cmake#L25

We are C++14.

We can move to C++17 for v1.1, I don't see any issues with that (I also don't see any need for it, as it does not introduce anything useful over C++14 imho).

But C++17 is our max, as C++20 requires major changes to the SDK's (and breaks current binary compatibility on Linux), and I have no plans writing anything that requires C++20 anyway.

[kaixoo12]

Oh, I thought we were on C++11 or previous. C++14 is fine. I think C++17 does some neat minor things so upgrading would be good too.

[kaixoo12]

Put C++ 17 instead of 20. I still don't understand where we were setting the standard previously.

[kaixoo12]

@rodlie could we merge this? If the changes look alright to you.

(I still dont know WHERE we were setting the C++ standard before, so maybe we should change it there instead)

[rodlie]

@rodlie could we merge this? If the changes look alright to you.

(I still dont know WHERE we were setting the C++ standard before, so maybe we should change it there instead)

Read my original reply #514 (comment)

[kaixoo12]

Okay. Just to let you know, C++17 does introduce some good things. But C++20 is the dealbreaker that adds a lot of conveniences. I wonder if the SDK could be upgraded. Is it libav that is the blocker? Or skia?