Parenteffect.cpp rework #599
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It all started playing around with a simple change to the line you highlighed to me:
https://github.com/friction2d/friction/blob/parent-effect-influence/src/core/TransformEffects/parenteffect.cpp#L92
postTransform.rotate(targetRot * (rotInfl - 1));but ended with AI support into a bigger thing but works way better than the previous one.
Now rotation influence works fine at any value and more important, its relative position to the parent doesn't get messed up:
Here is my little test file in case you want to play with it: parenting.zip
Let me know what do you think.