Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable passing options from resource init to get_table #222

Merged
merged 1 commit into from
Sep 4, 2018

Conversation

akariv
Copy link
Member

@akariv akariv commented Sep 3, 2018

Very similar to the way that these options are passed to the Storage.connect method,
we now use these options in the Table constructor in cases where storage is not used.

Very similar to the way that these options are passed to the Storage.connect method,
we now use these options in the Table consturctor when storage is not used.
@akariv akariv requested a review from roll September 3, 2018 14:02
Copy link
Member

@roll roll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@roll roll merged commit 108e2f1 into master Sep 4, 2018
@roll roll deleted the allow-get-table-options branch September 4, 2018 06:43
@roll
Copy link
Member

roll commented Sep 4, 2018

Releasing as v1.3.4 (it looks more like a fix of wrong behavior of the previous versions)

@akariv
Copy link
Member Author

akariv commented Sep 4, 2018

Thanks @roll 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants