Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty/Excel files by handling 'None' encoding #228

Merged
merged 2 commits into from
Oct 18, 2018
Merged

Allow empty/Excel files by handling 'None' encoding #228

merged 2 commits into from
Oct 18, 2018

Conversation

akariv
Copy link
Member

@akariv akariv commented Oct 17, 2018 •
edited
Loading

cchardet might return None as the encoding (could happen for empty files and, for example, when creating a resource based on an excel file).

Depends on frictionlessdata/tableschema-py#224

@akariv akariv requested a review from roll October 17, 2018 11:15
@akariv akariv force-pushed the fix/handle-empty-files branch from a7ea4da to 36d87b2 Compare October 17, 2018 17:58
@akariv akariv changed the title Allow empty files, handle 'None' encoding Allow empty/Excel files by handling 'None' encoding Oct 18, 2018
roll
roll approved these changes Oct 18, 2018
View reviewed changes
Copy link
Member

@roll roll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@roll roll merged commit cf56286 into master Oct 18, 2018
@roll roll deleted the fix/handle-empty-files branch October 18, 2018 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roll roll roll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akariv @roll