Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopped locking dependencies versions #232

Closed
wants to merge 1 commit into from
Closed

Stopped locking dependencies versions #232

wants to merge 1 commit into from

Conversation

KOLANICH
Copy link

No description provided.

@roll
Copy link
Member

roll commented Mar 25, 2019

Thanks!

@akariv
WDYT?

I think for Python our strategy is too aggressive.
At least we need to drop the maximum version.

@akariv
Copy link
Member

akariv commented Apr 6, 2019

You're probably right @roll -
The maximum version was originally there for things to be more predictable and not break when a dependency updates, bu usually what happens is that get a version mismatch with another library and things break anyway...

@roll roll closed this in 411675d Apr 11, 2019
@organman91
Copy link

organman91 commented Apr 16, 2019

It looks like this breaks things with the recent release of jsonschema. Running pip install 'datapackage<2.0,>=1.2' gives the warning tableschema 1.4.0 has requirement jsonschema<3.0,>=2.5, but you'll have jsonschema 3.0.1 which is incompatible.

@KOLANICH
Copy link
Author

Yet another argument against version locking. It is tableschema issue that it locks packages to old versions.

@KOLANICH KOLANICH deleted the stopped-locking-dependencies-versions branch April 16, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants