Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require tableschema>=1.12.1 #253

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Conversation

chris48s
Copy link
Member

@chris48s chris48s commented Dec 16, 2019

Overview

Hi. I tried to upgrade to datapackage 1.10.1 but found it is not compatible with Tableschema 1.12.0.

Steps to reproduce:

$ pip install datapackage==1.10.1
$ pip install tableschema==1.12.0
$ python3
>>> import datapackage
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/chris/.virtualenvs/datapackage-repro-gwcs1gD0/lib/python3.6/site-packages/datapackage/__init__.py", line 13, in <module>
    from .package import Package
  File "/home/chris/.virtualenvs/datapackage-repro-gwcs1gD0/lib/python3.6/site-packages/datapackage/package.py", line 20, in <module>
    from .resource import Resource
  File "/home/chris/.virtualenvs/datapackage-repro-gwcs1gD0/lib/python3.6/site-packages/datapackage/resource.py", line 17, in <module>
    from .profile import Profile
  File "/home/chris/.virtualenvs/datapackage-repro-gwcs1gD0/lib/python3.6/site-packages/datapackage/profile.py", line 13, in <module>
    import datapackage.registry
  File "/home/chris/.virtualenvs/datapackage-repro-gwcs1gD0/lib/python3.6/site-packages/datapackage/registry.py", line 11, in <module>
    from .exceptions import RegistryError
  File "/home/chris/.virtualenvs/datapackage-repro-gwcs1gD0/lib/python3.6/site-packages/datapackage/exceptions.py", line 11, in <module>
    DataPackageException = tableschema.DataPackageException
AttributeError: module 'tableschema' has no attribute 'DataPackageException'

This PR bumps the version requirement in setup.py to ensure a compatible version is installed, but maybe there is another issue to be raised on the tableschema repo because a non-backwards-compatible change was introduced in a patch release?

Cheers


Please preserve this line to notify @roll (lead of this repository)

@roll roll added the question label Dec 17, 2019
@roll
Copy link
Member

roll commented Dec 17, 2019

@chris48s
The [email protected] is very out-dated. Just curious why you don't use the latest one?

@chris48s chris48s changed the title Require tableschema>=1.2.1 Require tableschema>=1.12.1 Dec 17, 2019
@chris48s
Copy link
Member Author

Apologies for the confusion. I meant 1.12.0 and 1.12.1 not 1.2.0 and 1.2.1. I've updated the PR with the correct version numbers.

@roll
Copy link
Member

roll commented Dec 17, 2019

@chris48s
Thanks! It's a great catch

@roll roll merged commit 4422dcf into frictionlessdata:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants