-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define development process for v2+ #1052
Conversation
Deploying datapackage with
|
Latest commit: |
9579a07
|
Status: | ✅ Deploy successful! |
Preview URL: | https://96f061b2.datapackage-6gp.pages.dev |
Branch Preview URL: | https://929-contribution-guide.datapackage-6gp.pages.dev |
Hi @peterdesmet, can you please take a look? Once, it's merged we will have a free way to work on new versions I believe |
@roll I'll try to have a look this week. Can you already a a |
@peterdesmet
I will try to do so |
@peterdesmet |
I haven't, it's on my todo 😄
We could move it or make it easier have that file just refer to the (to be published) contributing guide on the website, cf. what I do here for the code of conduct: https://github.com/frictionlessdata/frictionless-r/blob/main/.github/CODE_OF_CONDUCT.md |
Agree, moved it to the repo root using a symlink |
Dear @frictionlessdata/data-package-vote, can you please also take a look as it's an important one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some small textual suggestions, all in all quite clear.
Line 99 in 8e4c6c0
1. A field type MUST NOT change default `format`. Example: does https://github.com/frictionlessdata/datapackage/pull/23 align with this? |
I think posing a question in an example will be confusing, it's definitely confused me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Helps make a lot of things clear.
Co-authored-by: Pieter Huybrechts <[email protected]>
Co-authored-by: Pieter Huybrechts <[email protected]>
Co-authored-by: Pieter Huybrechts <[email protected]>
Co-authored-by: Pieter Huybrechts <[email protected]>
Co-authored-by: Pieter Huybrechts <[email protected]>
Co-authored-by: Pieter Huybrechts <[email protected]>
Co-authored-by: Pieter Huybrechts <[email protected]>
@peterdesmet @PietrH @khughitt |
This PR finalizes set of actions to start with a new branch-based development model. I haven't found any suitable fully automated model like https://github.com/googleapis/release-please-action that matches our needs.
Anyway, the version updates are automated so for now we just need to maintain a releasing PR manually (which might be a good thing in the end).
Live preview - https://929-contribution-guide.datapackage-6gp.pages.dev/overview/contributing/