Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define development process for v2+ #1052

Merged
merged 20 commits into from
Mar 10, 2025
Merged

Define development process for v2+ #1052

merged 20 commits into from
Mar 10, 2025

Conversation

roll
Copy link
Member

@roll roll commented Oct 22, 2024


This PR finalizes set of actions to start with a new branch-based development model. I haven't found any suitable fully automated model like https://github.com/googleapis/release-please-action that matches our needs.

Anyway, the version updates are automated so for now we just need to maintain a releasing PR manually (which might be a good thing in the end).

Live preview - https://929-contribution-guide.datapackage-6gp.pages.dev/overview/contributing/

@roll roll marked this pull request as ready for review October 22, 2024 14:37
Copy link

cloudflare-workers-and-pages bot commented Oct 22, 2024

Deploying datapackage with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9579a07
Status: ✅  Deploy successful!
Preview URL: https://96f061b2.datapackage-6gp.pages.dev
Branch Preview URL: https://929-contribution-guide.datapackage-6gp.pages.dev

View logs

@roll roll requested review from peterdesmet and sapetti9 October 22, 2024 15:06
@roll
Copy link
Member Author

roll commented Oct 28, 2024

Hi @peterdesmet, can you please take a look? Once, it's merged we will have a free way to work on new versions I believe

@peterdesmet
Copy link
Member

@roll I'll try to have a look this week. Can you already a a .github/CONTRIBUTING.md (a default place for such a guide) and link to the web page?

@roll
Copy link
Member Author

roll commented Oct 28, 2024

@peterdesmet
Thanks!

Can you already a a .github/CONTRIBUTING.md (a default place for such a guide) and link to the web page?

I will try to do so

@roll
Copy link
Member Author

roll commented Dec 17, 2024

@peterdesmet
Have you had a chance to take a look? Or you would just like me to move CONTRIBUTING.md first?

@peterdesmet
Copy link
Member

Have you had a chance to take a look?

I haven't, it's on my todo 😄

Or you would just like me to move CONTRIBUTING.md first?

We could move it or make it easier have that file just refer to the (to be published) contributing guide on the website, cf. what I do here for the code of conduct: https://github.com/frictionlessdata/frictionless-r/blob/main/.github/CODE_OF_CONDUCT.md

@roll
Copy link
Member Author

roll commented Dec 23, 2024

Agree, moved it to the repo root using a symlink

@roll roll added the docs label Jan 27, 2025
@roll
Copy link
Member Author

roll commented Jan 27, 2025

Dear @frictionlessdata/data-package-vote,

can you please also take a look as it's an important one

@roll roll changed the title Added contribution guide Define development process after v2 Jan 27, 2025
@roll roll changed the title Define development process after v2 Define development process for v2+ Jan 27, 2025
Copy link
Member

@PietrH PietrH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some small textual suggestions, all in all quite clear.

1. A field type MUST NOT change default `format`. Example: does https://github.com/frictionlessdata/datapackage/pull/23 align with this?

I think posing a question in an example will be confusing, it's definitely confused me.

Copy link

@khughitt khughitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Helps make a lot of things clear.

roll and others added 3 commits March 10, 2025 14:22
Co-authored-by: Pieter Huybrechts <[email protected]>
Co-authored-by: Pieter Huybrechts <[email protected]>
Co-authored-by: Pieter Huybrechts <[email protected]>
@roll
Copy link
Member Author

roll commented Mar 10, 2025

@peterdesmet @PietrH @khughitt
Thanks a lot for helping with it! I'm merging it-- it unblocks the further versions work

@roll roll merged commit bf06cfc into main Mar 10, 2025
2 checks passed
@roll roll deleted the 929/contribution-guide branch March 10, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants