-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase on stricter types for fields #14
Conversation
@khusmann |
BEAUTIFUL! This is so nice to use: In addition to the code completion, the types here really help with mapping / translating between formats (and converting all the fields properly) because I can guarantee I've handled all the possible cases via exhaustiveness checking (less unit tests needed to catch runtime errors!). Thank you so much! Small suggestion -- I think you should make the This way, properties of constraints can return the correct types. For example, Related: I've proposed a |
@khusmann
Good catch! Added generics now |
Please make sure that all the checks pass. Please add here any additional information regarding this pull request. It's highly recommended that you link this PR to an issue (please create one if it doesn't exist for this PR)