Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 compatibility #72

Merged

Conversation

courtney-miles
Copy link
Collaborator

@courtney-miles courtney-miles commented Oct 27, 2023

Overview

Issue: #70

Updates package for PHP 8.1 compatibility.

  • Implementations of the methods for the \Iterator interface have had #[\ReturnTypeWillChange] added, since these methods have a return type as a PHP 8.1
  • strptime has been deprecated. StrptimeFormatTransformer has been introduced to convert a pattern from Python format to the format understood by date_parse_from_format. (I.e. %Y-%m-%d is changed to Y-m-d.)

Dev changes:

  • PHP CS Fixer has had it's version fixed to 3.4.0 as this is the last version with compatibility with PHP 7.2.
  • PHPUnit is pinned to versions between 7.5 and 10.0.
  • Test data provider methods have changed to static for compatibility with the next version of PHPUnit

@courtney-miles courtney-miles mentioned this pull request Oct 27, 2023
Copy link
Collaborator

@OriHoch OriHoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

the strptime change seems the most risky but I reviewed it and the code looks fine, also I guess it's fairly simple conversion of formats and the date/time tests pass so I guess it's good
👍

@courtney-miles courtney-miles merged commit 64d4bd8 into frictionlessdata:main Oct 29, 2023
@courtney-miles courtney-miles deleted the php81-compatibility branch October 29, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants