Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arg.6 and Arg.7 Added #52

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Arg.6 and Arg.7 Added #52

wants to merge 2 commits into from

Conversation

zendorx
Copy link

@zendorx zendorx commented Jan 8, 2025

I have added Arg.6 and Arg.7 and plan to add 3 more up to 10.
Please check my commits

@friflo
Copy link
Owner

friflo commented Jan 8, 2025

hi @zendorx,

massive work.
Already wrote a comment about PR's on Discord today.

"With PR's for main repo I hesitate to merge.
The main reason is I want to control the entire copyright of this project.
It allowed me to change the license to MIT in the past without being blocked by a contributor for whatever reasons.
I simply don't know how to handle this in GitHub without great circumstances so that it is legal flawless."

Beside this 8 Args is really enough. Other wise Signature gets too big.
sizeof(Signature) == 8
For 9 args it does not fit into a 64 bit and the Enumerator gets 8 bytes bigger.

@zendorx
Copy link
Author

zendorx commented Jan 8, 2025

Thank for the fast reply. I think it is enought to include some license for contributers to avoid that kind of problems (ex: https://github.com/coder/cla)

Any way I grant you any right for this code without any obligations from your side.

Beside this 8 Args is really enough. Other wise Signature gets too big.

In a big project it possible that query needed exclude or include more types than 8, so I think it there should be way to make it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants