Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speakers Section #4

Closed
wants to merge 5 commits into from
Closed

Speakers Section #4

wants to merge 5 commits into from

Conversation

dofxo
Copy link
Collaborator

@dofxo dofxo commented Jan 27, 2025

This PR has been created to review the merge of the speakers section branch into the dev branch.

Points to be addressed:

  1. Hardcoded Styles:

Some styles are currently hardcoded. Global styles, reusable classes, and standardized fonts should be created to address this issue.

  1. Speakers Data:

The current speakers' data is placeholder content and needs to be replaced with the actual data.

  1. RTL Direction:

The initiated PR lacks RTL support in the HTML direction, resulting in the output being displayed in LTR. This should be updated to align with RTL requirements where applicable.

dofxo added 5 commits January 27, 2025 18:05
in this commit i've added speaker section wrapper with its styles along
with  the title of it.
as mentioned in the code, hard coded sizes will be replaced with
tailwind custom configs (color, spacings at etc.)
in this commit i've added speakers data (not real data) to be able to
use them for the speakers sections
all the datas will be removed/replaced with the actual speakers data
…tion

these images are sample images for the speakers and will be repalced
with actual data
note: the current output of the card needs a rtl direction so the output
will become just like the design (it currently doesnt have the direction
as it is something to be placed in the layout)
Copy link

✨ Features

5b61d1a - add speakers section's wrapper with its title

in this commit i've added speaker section wrapper with its styles along
with the title of it.
as mentioned in the code, hard coded sizes will be replaced with
tailwind custom configs (color, spacings at etc.)

Changed files

  • src/app/page.tsx
  • src/components/sections/speakers/Speakers.tsx
48e8a13 - add speakers data

in this commit i've added speakers data (not real data) to be able to
use them for the speakers sections
all the datas will be removed/replaced with the actual speakers data

Changed files

  • src/components/sections/types.ts
  • src/data/speakers.ts
d081ff4 - add sample company-logo and profile-picture for the speaker section

these images are sample images for the speakers and will be repalced
with actual data

Changed files

  • public/images/speakers/company-logo/rasmio.svg
  • public/images/speakers/profile-picture/pooria-baba-ali.svg
225bff4 - add speaker component

note: the current output of the card needs a rtl direction so the output
will become just like the design (it currently doesnt have the direction
as it is something to be placed in the layout)

Changed files

  • src/components/sections/speakers/Speaker.tsx

📋 Changes

325f039 - modify:render speakers using speakers data

Changed files

  • src/components/sections/speakers/Speakers.tsx

@dofxo dofxo assigned dofxo and unassigned dofxo Jan 27, 2025
Copy link

✨ Features

5b61d1a - add speakers section's wrapper with its title

in this commit i've added speaker section wrapper with its styles along
with the title of it.
as mentioned in the code, hard coded sizes will be replaced with
tailwind custom configs (color, spacings at etc.)

Changed files

  • src/app/page.tsx
  • src/components/sections/speakers/Speakers.tsx
48e8a13 - add speakers data

in this commit i've added speakers data (not real data) to be able to
use them for the speakers sections
all the datas will be removed/replaced with the actual speakers data

Changed files

  • src/components/sections/types.ts
  • src/data/speakers.ts
d081ff4 - add sample company-logo and profile-picture for the speaker section

these images are sample images for the speakers and will be repalced
with actual data

Changed files

  • public/images/speakers/company-logo/rasmio.svg
  • public/images/speakers/profile-picture/pooria-baba-ali.svg
225bff4 - add speaker component

note: the current output of the card needs a rtl direction so the output
will become just like the design (it currently doesnt have the direction
as it is something to be placed in the layout)

Changed files

  • src/components/sections/speakers/Speaker.tsx

📋 Changes

325f039 - modify:render speakers using speakers data

Changed files

  • src/components/sections/speakers/Speakers.tsx

@dofxo dofxo closed this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants