-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speakers Section #4
Conversation
in this commit i've added speaker section wrapper with its styles along with the title of it. as mentioned in the code, hard coded sizes will be replaced with tailwind custom configs (color, spacings at etc.)
in this commit i've added speakers data (not real data) to be able to use them for the speakers sections all the datas will be removed/replaced with the actual speakers data
…tion these images are sample images for the speakers and will be repalced with actual data
note: the current output of the card needs a rtl direction so the output will become just like the design (it currently doesnt have the direction as it is something to be placed in the layout)
✨ Features5b61d1a - add speakers section's wrapper with its title
with the title of it. as mentioned in the code, hard coded sizes will be replaced with tailwind custom configs (color, spacings at etc.) |
✨ Features5b61d1a - add speakers section's wrapper with its title
with the title of it. as mentioned in the code, hard coded sizes will be replaced with tailwind custom configs (color, spacings at etc.) |
This PR has been created to review the merge of the speakers section branch into the dev branch.
Points to be addressed:
Some styles are currently hardcoded. Global styles, reusable classes, and standardized fonts should be created to address this issue.
The current speakers' data is placeholder content and needs to be replaced with the actual data.
The initiated PR lacks RTL support in the HTML direction, resulting in the output being displayed in LTR. This should be updated to align with RTL requirements where applicable.