Add Speakers section #8
Conversation
in this commit i've added speaker section wrapper with its styles along with the title of it. as mentioned in the code, hard coded sizes will be replaced with tailwind custom configs (color, spacings at etc.)
in this commit i've added speakers data (not real data) to be able to use them for the speakers sections all the datas will be removed/replaced with the actual speakers data
…tion these images are sample images for the speakers and will be repalced with actual data
note: the current output of the card needs a rtl direction so the output will become just like the design (it currently doesnt have the direction as it is something to be placed in the layout)
✨ Features5b61d1a - add speakers section's wrapper with its title
with the title of it. as mentioned in the code, hard coded sizes will be replaced with tailwind custom configs (color, spacings at etc.) |
Browser metadata |
src/components/sections/types.ts
Outdated
There was a problem hiding this comment.
تایپ‌ها باید کنار هر کامپوننت بصورت Speakers.d.ts قرار بگیرن
مگر اینکه تایپ کلی یا نامرتبط با کامپوننت فعلی باشن که باید تو مسیر src/types/something.d.ts قرار بگیرن
|
ممنونم بابت نکاتی که گفتید🙏🏻 برای تغییراتی که گفتید مربوط فونت و rtl |
سلامت باشی. نه کاملا اوکیه. هر جایی که نیاز به اعمال کانفیگ هست میتونیم تو همون برنچ اضافه‌اش کنیم. |
✨ Features5b61d1a - add speakers section's wrapper with its title
with the title of it. as mentioned in the code, hard coded sizes will be replaced with tailwind custom configs (color, spacings at etc.) |
✨ Features5b61d1a - add speakers section's wrapper with its title
with the title of it. as mentioned in the code, hard coded sizes will be replaced with tailwind custom configs (color, spacings at etc.) |
in this commit i've changed speakers img format to webp and company logo to png format
✨ Features5b61d1a - add speakers section's wrapper with its title
with the title of it. as mentioned in the code, hard coded sizes will be replaced with tailwind custom configs (color, spacings at etc.) |
in this commit i've changed some images styles to sync the new img format changes also changed some speaker component styles for better output
✨ Features5b61d1a - add speakers section's wrapper with its title
with the title of it. as mentioned in the code, hard coded sizes will be replaced with tailwind custom configs (color, spacings at etc.) |
in this commit i've replaced hard coded colors for background color with tailwind color classes
✨ Features5b61d1a - add speakers section's wrapper with its title
with the title of it. as mentioned in the code, hard coded sizes will be replaced with tailwind custom configs (color, spacings at etc.) |
✨ Features5b61d1a - add speakers section's wrapper with its title
with the title of it. as mentioned in the code, hard coded sizes will be replaced with tailwind custom configs (color, spacings at etc.) |
✨ Features5b61d1a - add speakers section's wrapper with its title
with the title of it. as mentioned in the code, hard coded sizes will be replaced with tailwind custom configs (color, spacings at etc.) |
✨ Features5b61d1a - add speakers section's wrapper with its title
with the title of it. as mentioned in the code, hard coded sizes will be replaced with tailwind custom configs (color, spacings at etc.) |
in this commit i've removed the dark theme prefrence from global css as it was not needed.
✨ Features5b61d1a - add speakers section's wrapper with its title
with the title of it. as mentioned in the code, hard coded sizes will be replaced with tailwind custom configs (color, spacings at etc.) |
in this commit i've added custom spacing based on design variables
✨ Features5b61d1a - add speakers section's wrapper with its title
with the title of it. as mentioned in the code, hard coded sizes will be replaced with tailwind custom configs (color, spacings at etc.) |
docs: add fulcain as a contributor for code
ci: setup all-contributor bot
this issues has been made from resolving conflicts from dev branch
Add Sponsers Section
docs: add Bravemobin as a contributor for code
AmirHosseinKarimi
force-pushed
the
dev
branch
3 times, most recently
from
6412e1f to
a9beae7
Compare
|
@all-contributors please add @dofxo as a contributor to their code. |
|
I've put up a pull request to add @dofxo! 🎉 |
This PR has been created to review the merge of the speakers section branch into the dev branch.
Points to be addressed:
Hardcoded Styles:
Some styles are currently hardcoded. Global styles, reusable classes, and standardized fonts should be created to address this issue.
Speakers Data:
The current speakers' data is placeholder content and needs to be replaced with the actual data.
RTL Direction:
The initiated PR lacks RTL support in the HTML direction, resulting in the output being displayed in LTR. This should be updated to align with RTL requirements where applicable.