Check for errors during FSEventStreamStart #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Adds an
errorreturn type to Start() and Restart() which returns non-nil if the underlying FSEventStream fails to start. This fixes #37Updates the README for the limits shown in #46 and #48 .
Where should the reviewer start?
I believe these are non-breaking changes, since the prior signatures did not return any value. Also it is helpful that the README notes this is an unstable API.
How should this be manually tested?
The included test case checks against issue #48 - both validating the limit of 4096 paths, and ensuring the error is propagated successfully.