Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test_move_recursive #575

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

ianthomas23
Copy link
Contributor

Closes #489.

Issue #489 has been fixed by the recent improvements to recursive path expansions. This PR adds an explicit test to confirm this and ensure that any future regressions are caught.

@martindurant
Copy link
Member

gcsfs/tests/test_core.py::test_gcs_glob now fails - any thoughts?

@martindurant
Copy link
Member

never mind, I think this was fixed in the follow-on ** PR

@martindurant
Copy link
Member

nope, still fails :|

@john-jam
Copy link
Contributor

You might want to merge main into this branch to have the updates.
The failing assert assert fn in gcs.glob(TEST_BUCKET + "/nested/") should be not in instead of in as done here.

This is because glob now returns directories if the path ends with a trailing slash according to posix rules.

@martindurant martindurant merged commit e64ede3 into fsspec:main Aug 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mv and rename not working as expected
3 participants